Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTypo in Libgen translator URL detection #1255
Conversation
This comment has been minimized.
This comment has been minimized.
|
thanks -- could you please add a test from the gen.lib.... domain (or substitute one of the libgen.io one)? |
adam3smith
merged commit ccaa082
into
zotero:master
Mar 11, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
owcz
deleted the
owcz:patch-4
branch
Mar 13, 2017
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
owcz commentedMar 11, 2017
See examples—order was switched in URL detection