Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[digibib.net.js]: Concatenate all notes together #1322

Merged
merged 1 commit into from Jun 25, 2017

Conversation

@zuphilip
Copy link
Collaborator

commented Jun 5, 2017

This solves https://forums.zotero.org/discussion/comment/276269

Moreover, some cleanup work:

  • delete Zotero.wait
  • activate all browserSupport
  • simplify detectWeb
  • delete unused parameter namespace in function _get_items_multi
  • replace some .match with .indexOf, simplify a regexp
@zuphilip
[digibib.net.js]: Concatenate all notes together 
This solves https://forums.zotero.org/discussion/comment/276269

Moreover, some cleanup work:
 * delete Zotero.wait
 * activate all browserSupport
 * simplify detectWeb
 * delete unused parameter namespace in function _get_items_multi
 * replace some .match with .indexOf, simplify a regexp
Loading status checks…
b6185c8

@adam3smith adam3smith merged commit b6b3a91 into zotero:master Jun 25, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Jun 25, 2017

Thanks!

@zuphilip zuphilip deleted the zuphilip:digi-notes branch Jun 25, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
[digibib.net.js]: Concatenate all notes together (zotero#1322) 
This solves https://forums.zotero.org/discussion/comment/276269

Moreover, some cleanup work:
 * delete Zotero.wait
 * activate all browserSupport
 * simplify detectWeb
 * delete unused parameter namespace in function _get_items_multi
 * replace some .match with .indexOf, simplify a regexp
36c0bb3

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
[digibib.net.js]: Concatenate all notes together (zotero#1322) 
This solves https://forums.zotero.org/discussion/comment/276269

Moreover, some cleanup work:
 * delete Zotero.wait
 * activate all browserSupport
 * simplify detectWeb
 * delete unused parameter namespace in function _get_items_multi
 * replace some .match with .indexOf, simplify a regexp
3689771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
You can’t perform that action at this time.