Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes VW #1337
+743
−875
Conversation
zuphilip
added some commits
Jun 17, 2017
adam3smith
reviewed
Jun 25, 2017
| for (var i=0; i<authorsList.length; i++) { | ||
| item.creators.push(ZU.cleanAuthor(authorsList[i], "author")); | ||
| } | ||
| } |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 25, 2017
Collaborator
Any objection to hardcoding the ISSN (0043-0633) for magazine Articles?
adam3smith
reviewed
Jun 25, 2017
WorldCat Discovery Service.js
Outdated
| "language": "English", | ||
| "libraryCatalog": "WorldCat Discovery Service", | ||
| "numPages": "xx, 404", | ||
| "place": "Peabody, Mass.", | ||
| "publisher": "Hendrickson Publishers Marketing", | ||
| "series": "Lexham Bible reference series; Lexham Bible reference series.", | ||
| "shortTitle": "Discourse grammar of the Greek New Testament", | ||
| "url": "Table of contents http://bvbr.bib-bvb.de:8991/F?func=service&doc_library=BVB01&local_base=BVB01&doc_number=024386228&line_number=0001&func_code=DB_RECORDS&service_type=MEDIA", |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 25, 2017
•
Collaborator
Not liking this. Could we do something like
- Check if URL is actually a URL
2 a) if it is, then import it into URL field
2 b) if it is not, check if it's a ToC and then turn it into attached link with appropriate title?
adam3smith
reviewed
Jun 25, 2017
|
Looks great -- I have two individual questions/comments. See what you think on those. Otherwise gtg. |
This comment has been minimized.
This comment has been minimized.
|
Please have a look at the new version. |
adam3smith
merged commit 64830cc
into
zotero:master
Jun 25, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Cool, thanks! |
zuphilip
deleted the
zuphilip:fixes-VW
branch
Jun 26, 2017
zuphilip
referenced this pull request
Mar 10, 2018
Closed
Winnipeg Free Press - completely broken after site update #128
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedJun 18, 2017
No description provided.