/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Bibliotheque et Archives Nationales du Quebec.js #1357

Merged
merged 3 commits into from Jul 8, 2017
+1 −1

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Collaborator

zuphilip commented Jul 6, 2017 •
edited
Edited 1 time
  • @zuphilip zuphilip edited Jul 6, 2017 (most recent)

This a test case for Travis as mentioned here #1351 (comment)

But was also asked in #459 (comment)
@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Jul 6, 2017

Collaborator

Okay, Travis fails when (git) renaming files. Now, I push (hopefully) the fix for this...
Collaborator

zuphilip commented Jul 6, 2017

Okay, Travis fails when (git) renaming files. Now, I push (hopefully) the fix for this...
@zuphilip
Handle renaming files in checkDeletedTxt.sh 
However, this sometimes do not work when the files
are renamed and rewritten (completelty) in Scaffold.
fd8dd71
@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Jul 6, 2017

Collaborator

This should handle the renames also in the test script for Travis. However, this works only for simple, nice renames. If one rewrite a translator completely and change the name in Scaffold (as the example in the fixes-T), then this might still lead to a fail in Travis.
Collaborator

zuphilip commented Jul 6, 2017

This should handle the renames also in the test script for Travis. However, this works only for simple, nice renames. If one rewrite a translator completely and change the name in Scaffold (as the example in the fixes-T), then this might still lead to a fail in Travis.
@zuphilip
Rename Radio Free Europe Radio Liberty.js 
This name is the automatic name according to the label.
0465102

@adam3smith adam3smith merged commit ad7df78 into zotero:master Jul 8, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Jul 8, 2017

Collaborator

Great, thanks
Collaborator

adam3smith commented Jul 8, 2017

Great, thanks

@zuphilip zuphilip deleted the zuphilip:test-rename branch Jul 8, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Rename Bibliotheque et Archives Nationales du Quebec.js (#1357) 
* Rename Bibliotheque et Archives Nationales du Quebec.js
* Handle renaming files in checkDeletedTxt.sh
However, this sometimes do not work when the files
are renamed and rewritten (completelty) in Scaffold.
* Rename Radio Free Europe  Radio Liberty.js
This name is the automatic name according to the label.
fed1305

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Rename Bibliotheque et Archives Nationales du Quebec.js (#1357) 
* Rename Bibliotheque et Archives Nationales du Quebec.js
* Handle renaming files in checkDeletedTxt.sh
However, this sometimes do not work when the files
are renamed and rewritten (completelty) in Scaffold.
* Rename Radio Free Europe  Radio Liberty.js
This name is the automatic name according to the label.
29bbbc4

@zuphilip zuphilip referenced this pull request Aug 9, 2018

Merged

Update Eurogamer for March 2018 redesign #1696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment