Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundesgesetzblatt.js: Fix pdfLink, permalink #1370

Merged
merged 2 commits into from Jul 22, 2017

Conversation

@zuphilip
Copy link
Collaborator

commented Jul 15, 2017

No description provided.

@adam3smith
Copy link
Collaborator

left a comment

just one quick quesiton

//e.g. media.xav/bgbl117s2262_75530.pdf?SID=&name=A730335D9081EC7D0035E5213AFA9AF8%2Fbgbl117s2262_75530.pdf&iid=75530
var m = embeddedPdf.match(/&name=([^&]+)/);
if (m) {
var pdfLink = '/xaver/bgbl/media/' + m[1].replace('%2F', '/');

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 22, 2017

Collaborator

Wouldn't this be better as m[1].decodeURIComponent?

This comment has been minimized.

Copy link
@zuphilip

zuphilip Jul 22, 2017

Author Collaborator

Yes, I will change that.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2017

Please have a look at the new version.

@adam3smith adam3smith merged commit 9e0215a into zotero:master Jul 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2017

Great, thanks!

@zuphilip zuphilip deleted the zuphilip:bgbl-pdf branch Jul 22, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.