Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd El Pais Translator #1514
Conversation
adam3smith
requested a review
from zuphilip
Jan 7, 2018
| } | ||
| } | ||
| item.publicationTitle = "El País"; | ||
| item.ISSN = "0213-4608"; |
This comment has been minimized.
This comment has been minimized.
zuphilip
Jan 7, 2018
Collaborator
That seems to be the ISSN of an weekly published international version between 1983 and 1999, see http://zdb-katalog.de/title.xhtml?idn=012116335 . Better numbers are 1134-6582 from http://zdb-katalog.de/title.xhtml?idn=011132388&tab=4 or 1576-3757 from https://www.wikidata.org/wiki/Q50009 .
| function detectWeb(doc, url) { | ||
| if (url.search(/\d+_\d+\.html/) !== -1) { | ||
| return "newspaperArticle"; | ||
| } else if ((url.includes("/buscador")||url.includes("/tag/")) && getSearchResults(doc, true)) { |
This comment has been minimized.
This comment has been minimized.
| } | ||
| item.publicationTitle = "El País"; | ||
| item.ISSN = "0213-4608"; | ||
| item.place = "Madrid"; |
This comment has been minimized.
This comment has been minimized.
zuphilip
Jan 7, 2018
Collaborator
I think they have offices in other cities as well. Is this really meaningful when extracting the online version?
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 7, 2018
Author
Collaborator
To the extent that citation styles want that information, El Pais (Madrid) is going to distinguish it from other El Pais papers which may exists e.g. in Latin Americal. ZDB also cites it as Madrid, so I'll leave this in.
| "libraryCatalog": "elpais.com", | ||
| "place": "Madrid", | ||
| "publicationTitle": "El País", | ||
| "section": "Mundo_global", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 7, 2018
Author
Collaborator
done -- I applied the title casing after replacing to get "Mundo Global" etc. in line with what the sections are called in the paper.
| //Z.debug(authors) | ||
| for (let author of authors) { | ||
| if (author !== "Agencias") { | ||
| item.creators.push(ZU.cleanAuthor(author, "author")) |
This comment has been minimized.
This comment has been minimized.
| "type": "web", | ||
| "url": "https://elpais.com/tag/estados_unidos/a/", | ||
| "items": "multiple" | ||
| }, |
This comment has been minimized.
This comment has been minimized.
zuphilip
Jan 7, 2018
Collaborator
Add another test case for search page, e.g. https://elpais.com/buscador/?qt=zotero
This comment has been minimized.
This comment has been minimized.
|
Thanks -- please have a look at updated version |
zuphilip
added some commits
Jan 7, 2018
zuphilip
merged commit a6b2412
into
zotero:master
Jan 7, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
zuphilip
added
the
New Translator
label
Jan 7, 2018
GuyAglionby
added a commit
to GuyAglionby/translators
that referenced
this pull request
Jan 28, 2018
psisquared2
added a commit
to psisquared2/translators
that referenced
this pull request
Feb 8, 2018
adam3smith commentedJan 7, 2018
supersedes #1146