Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BibTeX] Use location as event-place for conferences #1525

Merged
merged 4 commits into from Feb 4, 2019

Conversation

@zuphilip
Copy link
Collaborator

commented Jan 21, 2018

Moreover, in this way we make sure that the order of the fields
address and location in BibTeX don't matter. We take location
either as event-place in extra for conferenceArticles (e.g. for
ACM) or as a backup for the place field. This solves #1020.

Additionally, delete institution from inputField map because it
is already handled as an backupPublisher.

zuphilip added some commits Jan 21, 2018

[BibTeX] Use location as event-place for conferences
Moreover, in this way we make sure that the order of the fields
`address` and `location` in BibTeX don't matter. We take `location`
either as `event-place` in extra for conferenceArticles (e.g. for
ACM) or as a backup for the `place` field. This solves #1020.

Additionally, delete `institution` from inputField map because it
is already handled as an backupPublisher.

@zuphilip zuphilip requested a review from adam3smith Sep 1, 2018

"date": "2007",
"DOI": "10.1145/1281192.1281230",
"ISBN": "978-1-59593-609-7",
"extra": "event-place: San Jose, California, USA",

This comment has been minimized.

Copy link
@zuphilip

zuphilip Sep 1, 2018

Author Collaborator

We could also do the other direction, i.e. export such event-place fields for BibTeX.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 3, 2019

I still thinks this is a good idea. Any reactions? Ping @retorquere, @adam3smith

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Feb 4, 2019

Sorry about that -- yes, I agree this is good. Good to merge from my end -- I'd wait a couple of days to see if Emiliano has any concerns, otherwise one of us can merge.

retorquere added a commit to retorquere/zotero-better-bibtex that referenced this pull request Feb 4, 2019

retorquere added a commit to retorquere/zotero-better-bibtex that referenced this pull request Feb 4, 2019

retorquere added a commit to retorquere/zotero-better-bibtex that referenced this pull request Feb 4, 2019

@retorquere

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

Looks good to me, and thanks for the heads-up -- fixed in BBT now too.

@zuphilip zuphilip merged commit 8203550 into zotero:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:bibtex-location branch Feb 4, 2019

GuyAglionby added a commit to GuyAglionby/translators that referenced this pull request Mar 30, 2019

[BibTeX] Use location as event-place for conferences (zotero#1525)
Moreover, in this way we make sure that the order of the fields
`address` and `location` in BibTeX don't matter. We take `location`
either as `event-place` in extra for conferenceArticles (e.g. for
ACM) or as a backup for the `place` field. This solves zotero#1020.

Additionally, delete `institution` from inputField map because it
is already handled as an backupPublisher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.