Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd text search for GBV and LoC #1619
+23
−6
Conversation
dstillman
reviewed
Apr 12, 2018
Library of Congress ISBN.js
Outdated
| else if (item.query) { | ||
| url = "http://lx2.loc.gov:210/LCDB?operation=searchRetrieve&version=1.1&query=" + encodeURIComponent(item.query) + "&maximumRecords=50"; | ||
| } | ||
| else return; |
This comment has been minimized.
This comment has been minimized.
dstillman
Apr 12, 2018
Member
We'd want braces here for style reasons, but the else can just be removed from both translators. While at the moment we're not testing for query in detectSearch, the assumption in translators is always that the page/input should clear detect* in order for do* to be called (and it'd be fine for doGet to throw an error on an empty url if that didn't happen for some reason).
This comment has been minimized.
This comment has been minimized.
|
You need to update the timestamp of the two translators. |
This comment has been minimized.
This comment has been minimized.
|
This has a conflict with the GBV translator now. Can you rebase? |
mrtcode
force-pushed the
mrtcode:gbv-loc-text-search
branch
from
f2b5e3f
to
44a0e9a
Apr 16, 2018
dstillman
merged commit 79c2ecc
into
zotero:master
Apr 18, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mrtcode commentedApr 12, 2018
No description provided.