Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Deutsche Nationalbibliothek.js #1659
Conversation
zuphilip
added some commits
May 14, 2018
zuphilip
reviewed
May 19, 2018
MARCXML.js
Outdated
| //set tag to an empty string if this is the first subfield | ||
| if (k == 0) var tag = ""; | ||
| if (k == "0") tag = ""; | ||
| //concat all subfields in one datafield, with subfield delimiter and code between them |
This comment has been minimized.
This comment has been minimized.
zuphilip
merged commit d0f173c
into
zotero:master
May 19, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
zuphilip
deleted the
zuphilip:dnb-update
branch
May 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedMay 14, 2018
Delete non-sorting symbols in publisher field
as well and update tests. CC @sollbruchstellen