Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upNew translator for Harvard Business Review #1669
Conversation
zuphilip
reviewed
Jun 1, 2018
| // translator.setDocument(doc); | ||
|
|
||
| // TODO there are sometimes also more than one article on the same page | ||
| // e.g. https://hbr.org/2017/07/the-trouble-with-cmos#the-power-partnership |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 20, 2018
Collaborator
do you consider that a blocker or can we accept with this TODO?
This comment has been minimized.
This comment has been minimized.
zuphilip
Aug 20, 2018
Author
Collaborator
It is for me a major drawback: If I am in the middle of the page and want to save that article, then hit the Zotero button, it saves, but the article from the top.
zuphilip
added
the
New Translator
label
Jul 10, 2018
adam3smith
reviewed
Aug 20, 2018
|
I have a couple of questions left, but we should be able to take this. |
| // translator.setDocument(doc); | ||
|
|
||
| // TODO there are sometimes also more than one article on the same page | ||
| // e.g. https://hbr.org/2017/07/the-trouble-with-cmos#the-power-partnership |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 20, 2018
Collaborator
do you consider that a blocker or can we accept with this TODO?
adam3smith
added
the
waiting
label
Aug 20, 2018
zuphilip
reviewed
Aug 20, 2018
| translator.setHandler('itemDone', function (obj, item) { | ||
| // sometimes the section is also falsly part of the title from EM | ||
| item.title = text(doc, 'h1.article-hed') || text(doc, 'h2.article-hed') || item.title; | ||
| // sometitmes the creators are not yet extracted by EM |
This comment has been minimized.
This comment has been minimized.
zuphilip
changed the title
[WIP] New translator for Harvard Business Review
New translator for Harvard Business Review
Oct 10, 2018
zuphilip
removed
the
waiting
label
Oct 10, 2018
This comment has been minimized.
This comment has been minimized.
|
@adam3smith Okay, this is ready for review now. |
This comment has been minimized.
This comment has been minimized.
|
Looks good to me. When I'm running the tests (and importing), I don't get a publication title. Is that due to recent changes we made to EM? If so, could we add this in manually? Also, please manually add the ISSN |
This comment has been minimized.
This comment has been minimized.
|
Yes, with the new version of the EM translator we need to add |
This comment has been minimized.
This comment has been minimized.
|
Please have a look at the new version. |
adam3smith
merged commit dd5bf1c
into
zotero:master
Oct 11, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Great, thanks! |
zuphilip
deleted the
zuphilip:hbr
branch
Oct 11, 2018
zuphilip commentedJun 1, 2018
•
edited
New translator for Harvard Business Review