Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neural information processing systems #1747

Merged
merged 2 commits into from Sep 28, 2018

Conversation

@GuyAglionby
Copy link
Contributor

commented Sep 17, 2018

  • Amended target regex -- books.nips.cc doesn't seem to be used
  • Support saving from author pages
  • Support saving from search results
  • Support saving from pdf

Thanks!

GuyAglionby and others added some commits Sep 17, 2018

@GuyAglionby
Update neural information processing systems
Verified
This commit was signed with a verified signature.
GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
Loading status checks…
5d6b331
@adam3smith
optimize behavior on PDF page
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dfc7b21
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Sep 28, 2018

just to explain these changes: adding attachments by using the current document doesn't check for mimeType, so I think this would have imported two PDFs on the PDF page (and it definitely wouldn't have gotten the Snapshot of the item page, producing inconsistent behavior). Instead I'm distinguishing between the two cases in the attachment behavior.

@adam3smith adam3smith merged commit 9a431bc into zotero:master Sep 28, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Sep 28, 2018

Thanks!
@GuyAglionby

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 28, 2018

Makes sense -- thanks for the catch :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@GuyAglionby @adam3smith
You can’t perform that action at this time.