Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Engineering Village #1753
Conversation
adam3smith
and others
added some commits
Sep 27, 2018
zuphilip
reviewed
Oct 7, 2018
|
Please have a look at my changes and suggestions for another modification. If we can change that as well, then you should also add the AGPL license as it looks that almost everything changed here from the beginning. AFAIK I have not access to this database. |
Engineering Village.js
Outdated
| if (!title) continue; | ||
|
|
||
| if (checkOnly) return true; | ||
| found = true; | ||
|
|
||
| items[docid] = { | ||
| title: ZU.trimInternal(title.textContent), | ||
| checked: checkbox.checked | ||
| } | ||
| checked: checkbox.checked // TODO is this still needed? |
This comment has been minimized.
This comment has been minimized.
zuphilip
Oct 7, 2018
Collaborator
It looks for me that this is not anymore needed and therefore we can also switch to our default template for the function getSearchResults. Can you try that out @adam3smith ?
| function getSearchResults(doc, checkOnly) { | ||
| var rows = doc.getElementsByClassName('result'), | ||
| var rows = doc.querySelectorAll('div[class*=result-row]'), |
This comment has been minimized.
This comment has been minimized.
zuphilip
Oct 7, 2018
Collaborator
FYI A comma (not semi-colon) because several variables are defined here.
adam3smith
merged commit 686ee8c
into
zotero:master
Oct 8, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
adam3smith
deleted the
adam3smith:EV-update
branch
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adam3smith commentedSep 27, 2018
after some site changes. Thankfully small changes -- the post request happens in a window,that only pops up briefly & then closes. This wouldn't have been fun to re-create...