Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix multiple items for douban.com #1762
Conversation
JanusChoi
added some commits
Oct 9, 2018
zuphilip
reviewed
Oct 9, 2018
|
This looks fine in general. Please look at the comments and let us know when you have changed those. |
This comment has been minimized.
This comment has been minimized.
|
Did you made sure that the test cases are still working as before? This is easy to test when you use Scaffold plugin within Zotero. |
zuphilip
changed the title
Fix DoWeb for importing multiple items in page
Fix multiple items for douban.com
Oct 9, 2018
JanusChoi
added some commits
Oct 10, 2018
This comment has been minimized.
This comment has been minimized.
Thanks for the review! Yes, I've already tested two links from the test cases and they work fine in Scaffold. |
zuphilip
merged commit 21e60d6
into
zotero:master
Oct 11, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thank you very much @JanusChoi ! Merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
JanusChoi commentedOct 9, 2018
The original Xpath
//div/a[contains(@onclick, "moreurl")]is not working and I replace it with//div[@class="title"]/a'and modified following code in order to import multiple items in doulist or search result pages.