Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSpark 3.0.0 + Java 11 support. #375
+84
−285
Conversation
…talled :facepalm:, and a bunch more pom cleanup.
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 10, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
============================================
+ Coverage 76.36% 78.92% +2.56%
- Complexity 0 61 +61
============================================
Files 40 40
Lines 1413 1082 -331
Branches 268 114 -154
============================================
- Hits 1079 854 -225
+ Misses 217 184 -33
+ Partials 117 44 -73 |
This comment has been minimized.
This comment has been minimized.
This is awesome! Did a quick check, everything looks sane to me. |
src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Thanks for this @ruebot! Have built it locally, but will take my time to exhaustively run through the docs before giving it the thumbs up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedNov 10, 2019
•
edited
GitHub issue(s): #356
What does this Pull Request do?
Mostly
pom.xml
updates. Lots of cleanup, and updates. Big stuff, update to Apache Spark 3.0.0, and Java 11.How should this be tested?
Additional Notes:
--packages
. We hit an ugly dependency wall really quick. If we exclude, all the tests fail really bad. If I explicitly include it as a dependency, same thing. Tests fail really bad.--packages
.