Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 3.0.0 + Java 11 support. #375

Draft
wants to merge 13 commits into
base: master
from
+84 −285

Conversation

@ruebot
Copy link
Member

ruebot commented Nov 10, 2019 •
edited

GitHub issue(s): #356

What does this Pull Request do?

Mostly pom.xml updates. Lots of cleanup, and updates. Big stuff, update to Apache Spark 3.0.0, and Java 11.

How should this be tested?

  • TravisCI
  • Exhaustive regression testing; basically hit everything in the documentation, and make sure it works.

Additional Notes:

  • BIG KICKER
    • I cannot get this to work with --packages. We hit an ugly dependency wall really quick. If we exclude, all the tests fail really bad. If I explicitly include it as a dependency, same thing. Tests fail really bad.
  • I'm going to leave this as a draft, and we shouldn't merge until there is an official Spark 3.0.0 release, and we make a decision on --packages.
  • We'll squash this all down, and make a nice commit message when the time comes.
ruebot added 5 commits Aug 31, 2019
@ruebot
Initial Java 11 setup (#356); still need Spark compiled with Java 11 …
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
04a80d6 
…to get tests passing https://stackoverflow.com/questions/53583199/pyspark-error-unsupported-class-file-major-version-55
@ruebot
Merge branch 'master' of github.com:archivesunleashed/aut into issue-356
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
1c2ff7c
@ruebot
Update to Spark 3.0.0
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
8a51a87 
- Some hacks to get a sucessful build
- Definitely need to loop back and clean-up a whole lot!
- Addresses #356
@ruebot
#356 scala updates
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
06764f7
@ruebot
#356 verify-javadocs fixed -- make sure you have OpenJDK-11 fully ins…
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
d301adc 
…talled :facepalm:, and a bunch more pom cleanup.
@ruebot ruebot requested review from lintool and ianmilligan1 Nov 10, 2019
ruebot added 4 commits Nov 10, 2019
@ruebot
#356 update TravisCI; don't allow failures on Java 11.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
c86c398
@ruebot
#356 :facepalm: oops. uncommented that, and pushed.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
4a54d67
@ruebot
#356 Replace Cobertura with JaCoCo, and allow Java 8 to fail for now.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
41d5f45
@ruebot
#356 -- forgot to remove cobertura TravisCI build.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
b002a02
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Nov 10, 2019 •
edited

Codecov Report

Merging #375 into master will increase coverage by 2.56%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #375      +/-   ##
============================================
+ Coverage     76.36%   78.92%   +2.56%     
- Complexity        0       61      +61     
============================================
  Files            40       40              
  Lines          1413     1082     -331     
  Branches        268      114     -154     
============================================
- Hits           1079      854     -225     
+ Misses          217      184      -33     
+ Partials        117       44      -73
@lintool

This comment has been minimized.

Sign in to view
Copy link
Member

lintool commented Nov 10, 2019

This is awesome! Did a quick check, everything looks sane to me.
@ruebot
ruebot reviewed Nov 10, 2019
View changes
src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala Outdated Show resolved Hide resolved
ruebot added 3 commits Nov 10, 2019
@ruebot
#356 remove test line.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
d1692b5
@ruebot
#356 wave goodbye to Java 8.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
a1b9607
@ruebot
#356 add Java 11 and Spark 3.0.0+ to README
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
3b6744c
@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

ianmilligan1 commented Nov 10, 2019

Thanks for this @ruebot! Have built it locally, but will take my time to exhaustively run through the docs before giving it the thumbs up.
@ruebot
Merge branch 'master' into issue-356
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d59f9e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintool lintool

@ianmilligan1 ianmilligan1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @lintool @ianmilligan1
You can’t perform that action at this time.