Add checkstyle plugin, and remove demo; resolves #3 #17. #19

ruebot · Jul 17, 2017

Add checkstyle plugin
Add suppression files for checkstyle
Address checkstyle warnings
Add javadocs where necessary
Remove demo

@lintool I could use your eyes on this one, especially with the javadocs. Hopefully I captured everything accurately.

Grrr. I forgot to pull down master.

ruebot · Jul 17, 2017

Grrr. I forgot to pull down master.

Codecov Report

Merging #19 into master will increase coverage by 3.27%.
The diff coverage is 72.5%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   40.13%   43.41%   +3.27%     
==========================================
  Files          43       42       -1     
  Lines         897      850      -47     
  Branches      150      148       -2     
==========================================
+ Hits          360      369       +9     
+ Misses        493      437      -56     
  Partials       44       44

Impacted Files	Coverage Δ
...ava/io/archivesunleashed/io/ArcRecordWritable.java	`65.21% <66.66%> (+1.58%)`	⬆️
...ivesunleashed/mapreduce/WacGenericInputFormat.java	`73.07% <66.66%> (ø)`	⬆️
...ava/io/archivesunleashed/data/WarcRecordUtils.java	`61.53% <66.66%> (+0.42%)`	⬆️
...rchivesunleashed/mapreduce/WacWarcInputFormat.java	`75.6% <66.66%> (ø)`	⬆️
...archivesunleashed/mapreduce/WacArcInputFormat.java	`75.6% <66.66%> (ø)`	⬆️
...va/io/archivesunleashed/io/WarcRecordWritable.java	`65.21% <66.66%> (+1.58%)`	⬆️
...java/io/archivesunleashed/data/ArcRecordUtils.java	`85.29% <77.77%> (-2.21%)`	⬇️
...ivesunleashed/io/GenericArchiveRecordWritable.java	`68.08% <85.71%> (+2.96%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962bcf3...0ec8ab1. Read the comment docs.

codecov · Jul 17, 2017

Codecov Report

Merging #19 into master will increase coverage by 3.27%.
The diff coverage is 72.5%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   40.13%   43.41%   +3.27%     
==========================================
  Files          43       42       -1     
  Lines         897      850      -47     
  Branches      150      148       -2     
==========================================
+ Hits          360      369       +9     
+ Misses        493      437      -56     
  Partials       44       44

Impacted Files	Coverage Δ
...ava/io/archivesunleashed/io/ArcRecordWritable.java	`65.21% <66.66%> (+1.58%)`	⬆️
...ivesunleashed/mapreduce/WacGenericInputFormat.java	`73.07% <66.66%> (ø)`	⬆️
...ava/io/archivesunleashed/data/WarcRecordUtils.java	`61.53% <66.66%> (+0.42%)`	⬆️
...rchivesunleashed/mapreduce/WacWarcInputFormat.java	`75.6% <66.66%> (ø)`	⬆️
...archivesunleashed/mapreduce/WacArcInputFormat.java	`75.6% <66.66%> (ø)`	⬆️
...va/io/archivesunleashed/io/WarcRecordWritable.java	`65.21% <66.66%> (+1.58%)`	⬆️
...java/io/archivesunleashed/data/ArcRecordUtils.java	`85.29% <77.77%> (-2.21%)`	⬇️
...ivesunleashed/io/GenericArchiveRecordWritable.java	`68.08% <85.71%> (+2.96%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962bcf3...0ec8ab1. Read the comment docs.

@lintool

@lintool should be good to go. Let me know if there are any issues from your perspective.

ruebot · Jul 18, 2017

@lintool should be good to go. Let me know if there are any issues from your perspective.

lgtm - shipit!

lintool · Jul 31, 2017

lgtm - shipit!

ruebot assigned lintool Jul 17, 2017

don't need this either

Verified

This commit was signed with a verified signature.

ruebot Nick Ruest

GPG key ID: 417FAF1A0E1080CD Learn about signing commits

Loading status checks…

0ec8ab1

ruebot referenced this pull request Jul 27, 2017
Closed
Retarget Hadoop #9

ruebot deleted the issue-3 branch Jul 31, 2017

ruebot added this to Done in 1.0.0 Release of AUT Aug 25, 2017

archivesunleashed/aut

Add checkstyle plugin, and remove demo; resolves #3 #17. #19

ruebot commented Jul 17, 2017

ruebot assigned lintool Jul 17, 2017

This comment has been minimized.

ruebot commented Jul 17, 2017

ruebot added some commits Jul 17, 2017

This comment has been minimized.

codecov bot commented Jul 17, 2017 •

edited

This comment has been minimized.

ruebot commented Jul 18, 2017

ruebot referenced this pull request Jul 27, 2017

Retarget Hadoop #9

This comment has been minimized.

lintool commented Jul 31, 2017

lintool merged commit `bb2e665` into master Jul 31, 2017
4 checks passed

4 checks passed

ruebot deleted the issue-3 branch Jul 31, 2017

ruebot added this to Done in 1.0.0 Release of AUT Aug 25, 2017

archivesunleashed/aut

Join GitHub today

Add checkstyle plugin, and remove demo; resolves #3 #17. #19

Conversation

ruebot commented Jul 17, 2017

ruebot assigned lintool Jul 17, 2017

This comment has been minimized.

ruebot Jul 17, 2017

ruebot commented Jul 17, 2017

ruebot added some commits Jul 17, 2017

This comment has been minimized.

codecov bot Jul 17, 2017

Codecov Report

codecov bot commented Jul 17, 2017 • edited

Codecov Report

This comment has been minimized.

ruebot Jul 18, 2017

ruebot commented Jul 18, 2017

ruebot referenced this pull request Jul 27, 2017

Retarget Hadoop #9

This comment has been minimized.

lintool Jul 31, 2017

lintool commented Jul 31, 2017

Hide details View details lintool merged commit bb2e665 into master Jul 31, 2017 4 checks passed

4 checks passed

ruebot deleted the issue-3 branch Jul 31, 2017

ruebot added this to Done in 1.0.0 Release of AUT Aug 25, 2017

codecov bot commented Jul 17, 2017 •

edited

lintool merged commit `bb2e665` into master Jul 31, 2017
4 checks passed