Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/aut-docs-new

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate PySpark setup into overall documentation. #16

Merged
merged 3 commits into from Oct 28, 2019
+358 −590

Conversation

@ruebot
Copy link
Member

ruebot commented Oct 26, 2019

  • Removes standalone PySpark documentation.
  • Incorporates PySpark setup into getting started documentation.
  • Incorporates PySpark examples into overall documentation.
  • Breaks out scaling documentation to it's own documentation.
  • Removes cruft.
  • Renames files so they're all lowercase now.
  • Updates README ToC
@ruebot
Incorporate PySpark setup into overall documentation.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
94d5cb8 
- Removes standalone PySpark documentation.
- Incorporates PySpark setup into getting started documentation.
- Incorporates PySpark examples into overall documentation.
- Breaks out scaling documentation to it's own documentation.
- Removes cruft.
- Renames files so they're all lowercase now.
- Updates README ToC
@ruebot ruebot requested review from lintool and ianmilligan1 Oct 26, 2019
@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

ianmilligan1 commented Oct 26, 2019

Awesome- will review this afternoon hopefully!
@ianmilligan1
ianmilligan1 requested changes Oct 26, 2019
View changes
Copy link
Member

ianmilligan1 left a comment

Some minor changes and suggestions, but otherwise this looks great. Thanks @ruebot !
current/README.md Outdated Show resolved Hide resolved
current/README.md Outdated Show resolved Hide resolved
current/README.md Outdated Show resolved Hide resolved
current/toolkit-lesson.md Outdated Show resolved Hide resolved
@ruebot
review
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
3a42fac
@ruebot ruebot force-pushed the torch-pyspark-only-page branch from c91dca3 to 3a42fac Oct 26, 2019
@ruebot
review
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
31d1e82
@ianmilligan1
ianmilligan1 approved these changes Oct 27, 2019
View changes
Copy link
Member

ianmilligan1 left a comment

Looks great! Happy to merge once @lintool gives a thumbs up? (Or he can merge)
@ianmilligan1 ianmilligan1 merged commit 4cc429a into master Oct 28, 2019
@ianmilligan1 ianmilligan1 deleted the torch-pyspark-only-page branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1

@lintool lintool

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.