Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd filter/keep by http status to RecordLoader class #315
Comments
greebie
added
enhancement
Scala
labels
Apr 8, 2019
ruebot
added
the
resolve before 0.18.0
label
Aug 17, 2019
ruebot
self-assigned this
Aug 17, 2019
ruebot
added a commit
that referenced
this issue
Aug 17, 2019
ruebot
added a commit
that referenced
this issue
Aug 17, 2019
ruebot
added a commit
that referenced
this issue
Aug 17, 2019
ianmilligan1
closed this
in
#347
Aug 17, 2019
ianmilligan1
added a commit
that referenced
this issue
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
greebie commentedApr 5, 2019
Is your feature request related to a problem? Please describe.
Now that we have http status as part of the ArchiveRecord class, it may make sense to include methods to filter and or keep record with particular status codes.
Describe the solution you'd like
Something like:
and same for
.keepHttpStatus
Describe alternatives you've considered
@edsu also suggested that users may already expect certain Http Statuses (e.g. 410) to be removed from
.keepValidPages()
as well.Additional context
See discussion in ArchivesUnleashed Slack Aut Channel.