Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRename DF functions to be consistent with Python DF functions. #379
+85
−85
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 40 40
Lines 1418 1418
Branches 268 268
=======================================
Hits 1080 1080
Misses 221 221
Partials 117 117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedNov 14, 2019
GitHub issue(s): #366
What does this Pull Request do?
Rename DF functions to be consistent with Python DF functions.
How should this be tested?
Additional Notes:
@lintool the only part of the issue I haven't resolved here is your proposal to move
WebArchivetoRecordLoader.loadArchiveson the Python side. I don't believe we can haveRecordLoader.loadArchivesas an actual class name. So, should we change things in the other direction or both directions? I've been naming avalwarcsa lot in my example. What if we did something like that? OrwebArchivesorwebarchives? Once we settle on something, I'll the PR out of draft.There will be a TONNE of documentation updates to do. If I could get a hand there, that'd be super helpful. @SamFritz @ianmilligan1 that of any interest?