Scala doesn't support function overloading with default arguments. For the RDD implementation, minWidth and minHeight arguments were optional. For the current data frame implementation, they are necessary. If it is required to be kept as optional, I can

1. Shift df implementation to a new object (ExtractPopularImagesDF)
   OR
2. give a new name to the method. (That would require calling method name along with the object at the time of implementation)

Codecov Report

Merging #382 into master will decrease coverage by 0.53%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   76.23%   75.69%   -0.54%     
==========================================
  Files          40       40              
  Lines        1422     1432      +10     
  Branches      268      268              
==========================================
  Hits         1084     1084              
- Misses        221      231      +10     
  Partials      117      117

A new method, ExtractPopularImagesDF makes sense to me. @ianmilligan1 @lintool work for you, or y'all prefer another path?

@SinghGursimran tests? 😃

A new method, ExtractPopularImagesDF makes sense to me. @ianmilligan1 @lintool work for you, or y'all prefer another path?

That makes sense to me too!

Let's use a different convention for "end-to-end" functionalities. One option would be to have all UDFs be verb phrases, e.g., ExtractX, and "end-to-end" functionalities be noun phrases. So this would be PopularImagesExtractor. That way it'll be clear on what to use in what context.

@lintool so, should we have @SinghGursimran change the existing RDD method to PopularImagesExtractorRDD, and this new one should be PopularImagesExtractorDF?

Yes, if you like my suggestion of nouns vs. verbs.

I.e., UDFs are verbs, "do this".
"Assemblies" are thing-doers.

Cool.

That make sense @SinghGursimran?

@ruebot
Ya! I will change accordingly.
Regarding tests, there's an orderBy() function in implementation. If the value of key is same it orders randomly. If the count of two image URLs is same, the order of Data Frame row might change on running the code again. For the archive in resources, all images appear only once that is they all have count one. Adding a static test won't be feasible in such a case.