Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop-rspec to version 1.36.0 #85
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Sep 29, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedSep 28, 2019
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
1.36.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 34 commits:
Merge pull request #824 from rubocop-hq/releaseBump version to 1.36.0Fix ChangelogMerge pull request #777 from rubocop-hq/improve-focus-copAdd Changelog entries for RSpec/Focus cop changesAdd pending examples to what Focus cop can detectFix focus detection for mixed array/hash metadataMerge pull request #819 from skillsmatter/auto-correct-CurrentPathExpectationImprove autocorrect for Capybara/CurrentPathExpectationMerge pull request #823 from pirj/empty-line-after-exampleAdd RSpec/EmptyLineAfterExample copMerge pull request #821 from pirj/edge-rubocop-dependency-checkAdd edge RuboCop support CI checkMerge pull request #804 from pirj/update-rubocop-and-use-children-matchingMerge pull request #812 from pirj/improve-instance_variable-cop-messageMerge pull request #816 from pirj/fix-expect_change-docs-and-specs-syntax-errorsFix syntax errors in RSpec/ExpectChange docs/specsImprove RSpec/InstanceVariable offence messageMerge pull request #810 from pirj/drop-specs-from-gemUse child matching in MultipleExpectations copUse children matching in AttributeDefinedStatically copUse children matching in Pending copUse children matching in DescribeClass copUpdate minimum required RuboCop versionRemove redundant files from gem distributionMerge pull request #805 from pirj/417_context_methodAdd ContextWorking copMerge pull request #802 from pirj/add-described-class-skip_blocks-documentationAdd missing `SkipBlocks` option documentationMerge pull request #797 from pirj/fix-example-wording-cop-multiline-literalFix autocorrect in RSpec/ExampleWordingMerge pull request #800 from pirj/fix-described_class-described_class-as-namespace-variableRemove excessive indentation in spec code exampleIgnore `described_class` being used in constantDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands