Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck version numbers #10
+22
−2
Conversation
This comment has been minimized.
This comment has been minimized.
|
No worries about all the PRs, this is all really great, and I'm really happy to see it all being used! I had forgot @mjordan was away most of this week helping run an Islandora Camp. Once he's done with that, we should be able to review them all. Thanks again for everything!! |
kba
and others
added some commits
Nov 7, 2018
ruebot
merged commit b95cda1
into
bagit-profiles:master
Nov 13, 2018
5 checks passed
ci/circleci: build-python27
Your tests passed on CircleCI!
Details
ci/circleci: build-python34
Your tests passed on CircleCI!
Details
ci/circleci: build-python35
Your tests passed on CircleCI!
Details
ci/circleci: build-python36
Your tests passed on CircleCI!
Details
ci/circleci: build-python37
Your tests passed on CircleCI!
Details
kba
deleted the
kba:check-version-numbers
branch
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kba commentedNov 7, 2018
This checks version numbers to be strings.
Sorry for the PR spam, this is the last one.
(blocked by #7)