Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up
+160
−34
Conversation
kba
added some commits
Nov 19, 2018
This comment has been minimized.
This comment has been minimized.
Weird. CircleCI hasn't run. Other than that, nice work! |
ruebot
requested review from
mjordan and
ruebot
Nov 20, 2018
kba
force-pushed the
kba:validate-tag-files-allowed
branch
from
80392d0
to
e9dc615
Nov 20, 2018
This comment has been minimized.
This comment has been minimized.
Force-pushed to trigger CircleCI, tests pass now. |
kba
force-pushed the
kba:validate-tag-files-allowed
branch
from
a85b66f
to
6ecf798
Nov 29, 2018
ruebot
merged commit edfc0de
into
bagit-profiles:master
Dec 5, 2018
5 checks passed
ci/circleci: build-python27
Your tests passed on CircleCI!
Details
ci/circleci: build-python34
Your tests passed on CircleCI!
Details
ci/circleci: build-python35
Your tests passed on CircleCI!
Details
ci/circleci: build-python36
Your tests passed on CircleCI!
Details
ci/circleci: build-python37
Your tests passed on CircleCI!
Details
This comment has been minimized.
This comment has been minimized.
Huh. This is now failing locally for me, and on CircleCI. Did I miss something? |
This comment has been minimized.
This comment has been minimized.
Fixed the error in #16 |
kba
deleted the
kba:validate-tag-files-allowed
branch
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kba commentedNov 19, 2018
c.f. bagit-profiles/bagit-profiles#14
Tag-Files-Required
is a subset ofTag-Files-Allowed
Tag-Files-Allowed
In both cases wildcards (i.e.
fnmatch
patterns) are respected.Also simplifies how
validate()
calls the individual validation methods and saves errors on a propertyreport
to inspect the errors detected in each call ofvalidate()
.