New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile version #17

Merged
merged 4 commits into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@kba
Contributor

kba commented Dec 6, 2018

No description provided.

@kba kba referenced this pull request Dec 6, 2018

Merged

Fixes #16

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Dec 7, 2018

Want to update this one, and #15, and I can test/merge if everything goes well.

@kba kba force-pushed the kba:profile-version branch from 80279a6 to 7fa9650 Dec 7, 2018

@kba

This comment has been minimized.

Contributor

kba commented Dec 7, 2018

Updated, I hope nothing got lost rebasing. If you merge #15 and then #17, there won't be a need to squash commits.

test.py Outdated
@@ -60,17 +60,25 @@ def setUp(self):
self.profile_dict = json.loads(self.profile_str)
def test_profile_kwarg(self):
profile_url = Profile(PROFILE_URL)
# FIXME re-enable once sample updated upstream

This comment has been minimized.

@ruebot

ruebot Dec 10, 2018

Collaborator

Do I need to uncomment this after it is merged?

This comment has been minimized.

@kba

kba Dec 10, 2018

Contributor

Once the samples are versioned in the profiles spec repo, this can be reenabled. Best to wait until bagit-profiles/bagit-profiles#17 is merged, so the samples are in sync again.

@ruebot

ruebot approved these changes Dec 10, 2018

@ruebot ruebot merged commit 386156e into bagit-profiles:master Dec 10, 2018

5 checks passed

ci/circleci: build-python27 Your tests passed on CircleCI!
Details
ci/circleci: build-python34 Your tests passed on CircleCI!
Details
ci/circleci: build-python35 Your tests passed on CircleCI!
Details
ci/circleci: build-python36 Your tests passed on CircleCI!
Details
ci/circleci: build-python37 Your tests passed on CircleCI!
Details

@kba kba deleted the kba:profile-version branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment