/bagit-profiles-validator

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: use argparse, clearer logging logic #19

Merged
merged 7 commits into from Jan 17, 2019
+58 −43

Conversation

Reviewers

@ruebot ruebot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kba @ruebot
@kba
Copy link
Contributor

kba commented Jan 17, 2019

  • optparse is deprecated
  • logging logic was broken (logging to file could not be disabled / logging to console not be enabled)
  • version flag
  • support variant of constructor which doesn't require fetching URL
  • exits 1 for serialization error
  • exits 2 for validation error

It should be backwards-compatible to not break existing scripts.

kba added some commits Jan 17, 2019

@kba
CLI: use argparse, clearer logging logic
5ee87b4
@kba
Merge branch 'master' into improve-cli
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f3ae024
@kba
CLI: --report to print report after validation fails
Loading status checks…
577af28
@kba
CLI: State defaults
Loading status checks…
2f53ae0
@kba
CLI: --skip-serialization to skip serialization validation
Loading status checks…
6db84a7
@kba
CLI: --skip option to skip serialization or profile validation steps
26f0638
@kba
unicode literals to make 27 happy
Loading status checks…
f59caab

@kba kba force-pushed the kba:improve-cli branch from d8c11b0 to f59caab Jan 17, 2019

@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member

ruebot commented Jan 17, 2019

Thanks!! Good catch on the logging logic!
@ruebot

ruebot approved these changes Jan 17, 2019
View changes

@ruebot ruebot merged commit a6012c4 into bagit-profiles:master Jan 17, 2019
5 checks passed

5 checks passed

ci/circleci: build-python27 Your tests passed on CircleCI!
Details
ci/circleci: build-python34 Your tests passed on CircleCI!
Details
ci/circleci: build-python35 Your tests passed on CircleCI!
Details
ci/circleci: build-python36 Your tests passed on CircleCI!
Details
ci/circleci: build-python37 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment