Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed term on access macro, added rules for bill #4407

Open
wants to merge 3 commits into
base: master
from

Conversation

@abeeken
Copy link
Contributor

abeeken commented Nov 13, 2019

No description provided.

@abeeken
Changed term on access macro, added rules for bill
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b458ae0
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Nov 13, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Nov 13, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

university-of-lincoln-harvard.csl (modified style; unchanged output for sample items)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)
CSL search by example (2012) Available from http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012].
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. and Clark, T. (2019) A data citation roadmap for scholarly data repositories. Scientific Data, 6(1) 28. Available from http://www.nature.com/articles/s41597-019-0031-8 [accessed 27 April 2019].
Hancké, B., Rhodes, M. and Thatcher, M. (eds.) (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall and D. Soskice (eds.) Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 184–213.
@adam3smith
adam3smith reviewed Nov 14, 2019
View changes
university-of-lincoln-harvard.csl Outdated
<text term="available at" text-case="capitalize-first" suffix=" "/>
<text variable="URL"/>
<if type="bill webpage article-journal article-newspaper" match="any">
<text variable="URL" prefix="Available from "/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Nov 14, 2019

Member

I don't understand why you switched this? Using the term should give you exactly the same and is generally preferable (e.g., makes the style more robust for adaptation)

This comment has been minimized.

Sign in to view
Copy link
@abeeken

abeeken Nov 14, 2019

Author Contributor

Hi Sebastian,

We switched this as for some reason the term wasn't appearing for a "bill" type citation - using the prefix worked fine.

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Nov 15, 2019

Member

that really shouldn't matter and we don't like to work around bugs in citation managers. Was that in Zotero or a different tool?

This comment has been minimized.

Sign in to view
Copy link
@abeeken

abeeken Nov 15, 2019

Author Contributor

No, it was while we were building the style in the CSL editor: https://editor.citationstyles.org/visualEditor/

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Nov 16, 2019

Member

Could you walk me through steps to reproduce that? It really shouldn't happen (and I'm quite surprised it would, so I'm suspecting something else may have been going on), but if it does it's a bug in the editor we want to fix rather than to fix something in the style that isn't broken (e.g. I just tested in Zotero and using the term for the bill is fine).

This comment has been minimized.

Sign in to view
Copy link
@abeeken

abeeken Nov 18, 2019

Author Contributor

I've checked myself and I can't actually reproduce it - not sure what was going on when I was working on this but I've put the tag back in and it's rendering fine now 🤷‍♂ I've committed the change again.
@abeeken
Added text back in
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e48889
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Nov 18, 2019

😟 There are some issues with your submission.

1 test failed

university-of-lincoln-harvard: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to return true, got false

Please check the test report for details.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Nov 18, 2019

(I'll fix validation; don't worry about it)
@adam3smith
Fix validation, use group...
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
13860bc 
...to prevent unwanted terms
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Nov 18, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

university-of-lincoln-harvard.csl (modified style; unchanged output for sample items)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)
CSL search by example (2012) Available from http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012].
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. and Clark, T. (2019) A data citation roadmap for scholarly data repositories. Scientific Data, 6(1) 28. Available from http://www.nature.com/articles/s41597-019-0031-8 [accessed 27 April 2019].
Hancké, B., Rhodes, M. and Thatcher, M. (eds.) (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall and D. Soskice (eds.) Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 184–213.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@abeeken @csl-bot @adam3smith
You can’t perform that action at this time.