Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upClean-up Atypon Journals.js from Emerald relicts #2046
+1
−54
Conversation
This comment has been minimized.
This comment has been minimized.
|
One could do some more work on this, but the test cases are not working within Scaffold. @dstillman Is it possible that this is a cookie problem? The translator calls a page for getting the citation data, but AFAIS this page is different from Scaffold than what I get in my browser. Especially, I see that the original document has set some cookie data |
This comment has been minimized.
This comment has been minimized.
|
I'll merge this, but I think the question above for @dstillman remains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zuphilip commentedNov 3, 2019
This finally closes #2036.