Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate CONTRIBUTING.rst #856
Conversation
Adding an example how to add a new sparql query to scholia
CONTRIBUTING.rst
Outdated
| 1. Assign the task for yourself (if it is in an issue tracker) | ||
| 2. Get the new query e.g. | ||
| E.g. | ||
| SELECT DISTINCT ?author ?authorLabel ?award ?awardLabel WHERE { |
This comment has been minimized.
This comment has been minimized.
fnielsen
Oct 15, 2019
Owner
There is a bit of a formatting issue with the code. Perhaps some indentation is needed?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I think I got it now... |
CONTRIBUTING.rst
Outdated
| e.g. authorAwardsSparql | ||
| 3. Add a name (within your own fork of the file https://github.com/fnielsen/scholia/tree/master/scholia[…]) e.g. authorAwardsSparql | ||
|
|
||
| .. code:: python |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CONTRIBUTING.rst
Outdated
| @@ -97,10 +100,14 @@ e.g. authorAwardsSparql | |||
| 4. Add that name to the sparql-to-data table | |||
|
|
|||
| .. code:: python | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CONTRIBUTING.rst
Outdated
| sparqlToDataTable(authorAwardsSparql, "#author-awards"); | ||
| 5. Add some table formatting | ||
|
|
||
| .. code:: html | ||
|
|
||
| <h2 id="AuthorAwards">Author Awards</h2> |
This comment has been minimized.
This comment has been minimized.
fnielsen
Oct 15, 2019
Owner
I think <h2 id="Author-awards">Author awards</h2> would be better, i.e., lower case section words, except the first. A make a dash in the id for the space.
This comment has been minimized.
This comment has been minimized.
| e.g. authorAwardsSparql | ||
| 3. Add a name (within your own fork of the file https://github.com/fnielsen/scholia/tree/master/scholia[…]) e.g. authorAwardsSparql | ||
|
|
||
| .. code:: python | ||
| authorAwardsSparql = |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here are a few issues you might consider
|
fnielsen
merged commit 037224f
into
fnielsen:master
1 check passed
1 check passed
security/snyk - requirements.txt (fnielsen)
No manifest changes detected
This comment has been minimized.
This comment has been minimized.
|
I have just done the issues. I hope they are ok? |
This comment has been minimized.
This comment has been minimized.
|
sure, thanks! |
AlexanderPico
added a commit
to wikipathways/scholia
that referenced
this pull request
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fehrhart commentedOct 15, 2019
Adding an example how to add a new sparql query to scholia