Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: geopolygon: retrieve and correctly reshape the polygon of a geographical area #1895
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1895 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/lib/whedon.rb:114:in |
This comment has been minimized.
This comment has been minimized.
@openjournals/dev -- S.O.S. All paper compilations are failing today! |
This comment has been minimized.
This comment has been minimized.
@CostRagno — I'm going to send this back to you for some work on the paper, which should not be a copy-paste of the README, but a narrative that explains the software functionality to a non-specialist, places the software in the general state of the art (e.g., any other software out there doing similar things?), and illustrates the research context where it might be used. Please take another look at the JOSS Author Guide. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1895 with the following error: Error reading bibliography ./paper.bib (line 24, column 3): |
This comment has been minimized.
This comment has been minimized.
@CostRagno - this PR should fix your paper compilation: CostRagno/geopolygon#1 |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1895 with the following error: [WARNING] Could not convert image '/tmp/tex2pdf.-d49d3a75c2cdd527/8370c256978f712e7ec28c3673c28cd1f86eca78.shtml': Cannot load file HDR Invalid radiance file signature HDR Invalid radiance file signature See the LaTeX manual or LaTeX Companion for explanation. l.451 ...56978f712e7ec28c3673c28cd1f86eca78.shtml} Looks like we failed to compile the PDF |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@CostRagno - this PR should fix your figures: CostRagno/geopolygon#2 |
This comment has been minimized.
This comment has been minimized.
@labarba thank you for your comments. We will work more on the paper based on your suggestions :) |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@arfon now it is perfectly working. Thank you very much. We had problems because the https://whedon.theoj.org/ do not generate the pdf and because it was our first joss submission. |
This comment has been minimized.
This comment has been minimized.
@CostRagno - is this paper ready to be moved on to review in your opinion? In other words, have you finished what you intended when you wrote the following?
|
This comment has been minimized.
This comment has been minimized.
Hi @CostRagno - I've consulted with the JOSS editorial team and we've concluded that this submission is not in scope for JOSS as it falls into our 'minor utility' category. For increased visibility, we would encourage you to consider contributing the code for polygon ordering upstream to the geopandas library. Alternatively, the general usability of the software could be improved by separating the algorithm for ordering the polygons (with focus on compatibility with geopandas and the rest of the Python geospatial stack) from the data fetching and specific use case of OpenStreetMap data. Thanks again for your interest in JOSS. |
whedon commentedNov 16, 2019
Submitting author: @CostRagno (Costantino Ragno)
Repository: https://github.com/CostRagno/geopolygon
Version: v0.1
Editor: Pending
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @CostRagno. Currently, there isn't an JOSS editor assigned to your paper.
@CostRagno if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: