Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create zfdg.csl #4394

Merged
merged 11 commits into from Nov 14, 2019

Conversation

@ZfdG
Copy link
Contributor

ZfdG commented Nov 6, 2019

CSL of the Zeitschrift für digitale Geisteswissenschaften (ZfdG).
More: https://www.zfdg.de

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 6, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 6, 2019

😟 There are some issues with your submission.

2 tests failed

zfdg: may not have any unused macros

expected: []
     got: ["collection", "title-short", "translatedby"]

(compared using ==)

zfdg: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-subsequent-min (1) to be greater than et-al-subsequent-use-first (1)

Please check the test report for details.

zfdg.csl Outdated Show resolved Hide resolved
zfdg.csl Outdated Show resolved Hide resolved
zfdg.csl Outdated Show resolved Hide resolved
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2019

😟 There are some issues with your submission.

2 tests failed

zeitschrift-fur-digitale-geisteswissenschaften: may not have any unused macros

expected: []
     got: ["collection", "title-short", "translatedby"]

(compared using ==)

zeitschrift-fur-digitale-geisteswissenschaften: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-subsequent-min (1) to be greater than et-al-subsequent-use-first (1)

Please check the test report for details.

Copy link
Member

adam3smith left a comment

Danke -- der Stil muesste noch ein bisschen aufgerauemt werden, ein paar Bitten und Fragen dazu inline.

zeitschrift-fur-digitale-geisteswissenschaften.csl Outdated Show resolved Hide resolved
zeitschrift-fur-digitale-geisteswissenschaften.csl Outdated Show resolved Hide resolved
zeitschrift-fur-digitale-geisteswissenschaften.csl Outdated Show resolved Hide resolved
<text variable="collection-title"/>
<choose>
<if is-numeric="collection-number">
<group delimiter=" ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Nov 8, 2019

Member

group mit nur einem Element tut nichts, also bitte rausnehmen

<macro name="container">
<choose>
<if type="post-weblog">
<text prefix=" In: " variable="container-title"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Nov 8, 2019

Member

eleganter waere es sachen wie "In", "Bd." etc. mit terms zu loesen statt in die affixe zu setzen.

<text prefix=". " macro="edition"/>
<text prefix=" (" suffix=")" variable="collection-title"/>
<text prefix=". " variable="publisher-place"/>
<text prefix=". " suffix=". " variable="note"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Nov 8, 2019

Member

Wofuer ist das? Wir sehen die Nutzung von note in Standad Stilen nur sehr ungern

This comment has been minimized.

Copy link
@ZfdG

ZfdG Nov 13, 2019

Author Contributor

Ups, das war mal für die interne Ausgabe einer internen ID zum Zweck der leichteren Überprüfung aus welchem Artikel die Angaben stammen. Habe ich entfernt, danke!

<date variable="issued" form="numeric" prefix=" (" suffix=")">
<date-part name="year"/>
</date>
<text variable="issue" prefix=", &#160;"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Nov 8, 2019

Member

wirklich space und non-breaking space? Das scheint mir unwahrscheinlich

zeitschrift-fur-digitale-geisteswissenschaften.csl Outdated Show resolved Hide resolved
<date-part name="year"/>
</date>
<choose>
<if variable="page" type="chapter" match="all">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Nov 8, 2019

Member

Ist das so gewollt, dass der locator nur gedruckt wird wenn ein Werk eine Seitenspanne hat? Das scheint mir seltsam

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2019

😟 There are some issues with your submission.

3 tests failed

zeitschrift-fur-digitale-geisteswissenschaften: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "74:46: FATAL: Couldn't find end of Start Tag label line 74"]].empty?` to return true, got false

zeitschrift-fur-digitale-geisteswissenschaften: may not have any unused macros

expected: []
     got: ["secondary-collection-contributors"]

(compared using ==)

zeitschrift-fur-digitale-geisteswissenschaften: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/zeitschrift-fur-digitale-geisteswissenschaften"
     got: "http://www.zotero.org/styles/zfdg"

(compared using ==)

Please check the test report for details.

ZfdG added 2 commits Nov 8, 2019
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2019

😟 There are some issues with your submission.

3 tests failed

zeitschrift-fuer-digitale-geisteswissenschaften: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "74:46: FATAL: Couldn't find end of Start Tag label line 74"]].empty?` to return true, got false

zeitschrift-fuer-digitale-geisteswissenschaften: may not have any unused macros

expected: []
     got: ["secondary-collection-contributors"]

(compared using ==)

zeitschrift-fuer-digitale-geisteswissenschaften: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/zeitschrift-fuer-digitale-geisteswissenschaften"
     got: "http://www.zotero.org/styles/zfdg"

(compared using ==)

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2019

😟 There are some issues with your submission.

2 tests failed

zeitschrift-fuer-digitale-geisteswissenschaften: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "74:46: FATAL: Couldn't find end of Start Tag label line 74"]].empty?` to return true, got false

zeitschrift-fuer-digitale-geisteswissenschaften: may not have any unused macros

expected: []
     got: ["secondary-collection-contributors"]

(compared using ==)

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2019

😟 There are some issues with your submission.

1 test failed

zeitschrift-fuer-digitale-geisteswissenschaften: may not have any unused macros

expected: []
     got: ["secondary-collection-contributors"]

(compared using ==)

Please check the test report for details.

adam3smith added 2 commits Nov 10, 2019
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 10, 2019

😟 There are some issues with your submission.

2 tests failed

zeitschrift-fuer-digitale-geisteswissenschaften: must define all macros that are called by <text/> and <key/> elements

expected #has_key?("secondary-container-contributors") to return true, got false

zeitschrift-fuer-digitale-geisteswissenschaften: may not have any unused macros

expected: []
     got: ["secondary-collection-contributors"]

(compared using ==)

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 10, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

zeitschrift-fuer-digitale-geisteswissenschaften.csl (new)
Hancké et al. 2007 2012.
Mares 2001Fenner et al. 10.04.2019.

CSL search by example. In: Citation Style Editor. 2012. http://editor.citationstyles.org/searchByExample/.
Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Hg. von Bob Hancké / Martin Rhodes / Mark Thatcher. Oxford and New York 2007.
Martin Fenner et al.: A data citation roadmap for scholarly data repositories. In: Scientific Data 6 (10.04.2019),  1, S. 28. http://www.nature.com/articles/s41597-019-0031-8.
Isabela Mares: Firms and the welfare state: When, why, and how does social policy matter to employers? In: Varieties of capitalism. The institutional foundations of comparative advantage. Hg. von Peter A. Hall / David Soskice. New York 2001, S. 184–213.
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 10, 2019

Das Zitat für herausgegebene Bücher (als ganze) sieht noch etwas seltsam aus. Ich würde davon ausgehen, dass da die Herausgeber als erstes, in der AutorInnen Position stehen sollten? Wie genau?

Dieses hier meine ich:
Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Hg. von Bob Hancké / Martin Rhodes / Mark Thatcher. Oxford and New York 2007.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 11, 2019

😟 There are some issues with your submission.

1 test failed

zeitschrift-fuer-digitale-geisteswissenschaften: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "151:8: FATAL: StartTag: invalid element name"]].empty?` to return true, got false

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 11, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

zeitschrift-fuer-digitale-geisteswissenschaften.csl (new)
Hancké et al. 2007 2012.
Mares 2001Fenner et al. 10.04.2019.

CSL search by example. In: Citation Style Editor. 2012. http://editor.citationstyles.org/searchByExample/.
Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Hg. von Bob Hancké / Martin Rhodes / Mark Thatcher. Oxford and New York 2007.
Martin Fenner et al.: A data citation roadmap for scholarly data repositories. In: Scientific Data 6 (10.04.2019),  1, S. 28. http://www.nature.com/articles/s41597-019-0031-8.
Isabela Mares: Firms and the welfare state: When, why, and how does social policy matter to employers? In: Varieties of capitalism. The institutional foundations of comparative advantage. Hg. von Peter A. Hall / David Soskice. New York 2001, S. 184–213.
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 12, 2019

Siehe bitte meine Frage bezueglich herausgegebener Bücher noch.

@ZfdG

This comment has been minimized.

Copy link
Contributor Author

ZfdG commented Nov 13, 2019

Zu den herausgegebenen Bänden: Ich Angaben entsprechen den Vorgaben der Zeitschrift:

"Herausgeberschriften/Sammelbände
Titel. Untertitel. Hg. von Vorname Name oder herausgebende Institution. Ausgabenbezeichnung. Erscheinungsort Erscheinungsjahr. (= Reihe, Reihenzählung).

Beispiele:

Kunstgeschichte digital. Eine Einführung für Praktiker und Studierende. Hg. von Hubertus Kohle. Berlin 1997.
Defining Digital Humanities. A Reader. Hg. von Melissa M. Terras / Julianne Nyhan / Edward Vanhoutte. 4. Auflage. Farnham 2013."

Die gesamtem Vorgaben sind zu finden unter:
http://www.zfdg.de/s-wie-style

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 13, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

zeitschrift-fuer-digitale-geisteswissenschaften.csl (new)
Hancké et al. 2007 2012.
Mares 2001Fenner et al. 10.04.2019.

CSL search by example. In: Citation Style Editor. 2012. http://editor.citationstyles.org/searchByExample/.
Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Hg. von Bob Hancké / Martin Rhodes / Mark Thatcher. Oxford and New York 2007.
Martin Fenner et al.: A data citation roadmap for scholarly data repositories. In: Scientific Data 6 (10.04.2019),  1, S. 28. http://www.nature.com/articles/s41597-019-0031-8.
Isabela Mares: Firms and the welfare state: When, why, and how does social policy matter to employers? In: Varieties of capitalism. The institutional foundations of comparative advantage. Hg. von Peter A. Hall / David Soskice. New York 2001, S. 184–213.
@adam3smith adam3smith merged commit 3327f79 into citation-style-language:master Nov 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 14, 2019

Super, besten Dank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.