Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate journal-of-neolithic-archaeology.csl #4398
Conversation
The category citation-format was defined twice which led to unwished behaviour (footnotes instead of in-text citations). In the proposed branch, the incriminating line is deleted.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 7, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 7, 2019
1 test failedjournal-of-neolithic-archaeology: must have a "class" attribute that matches the "citation-format" attribute
Please check the test report for details. |
This comment has been minimized.
This comment has been minimized.
Thanks. From a quick view of the styleguide, it'd seem like citations should also be in parentheses, right? Currently this does |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 8, 2019
Below are some sample citations generated based on your proposed changes: journal-of-neolithic-archaeology.csl (modified style; unchanged output for sample items)Hancké et al. 2007; CSL search by example 2012 |
Two more small changes: the in-text-names of the authors are not supposed to appear in small caps, neither the dois.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 9, 2019
Below are some sample citations generated based on your proposed changes: journal-of-neolithic-archaeology.csl (modified style)Hancké et al. 2007; CSL search by example 2012 Hancké et al. 2007; CSL search by example 2012<br/>
-<span style="font-variant: small-caps">Mares</span> 2001; <span style="font-variant: small-caps">Fenner et al.</span> 2019<br/>
+Mares 2001; Fenner et al. 2019<br/>
<hr/>
<div class="csl-left-margin">CSL search by example 2012: </div>CSL search by example, 2012<div class="csl-block">.&#10;http://editor.citationstyles.org/searchbyexample/ [December 15, 2012]</div>.<br/>
-<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&#10;<span style="font-variant: small-caps">doi: </span>10.1038/s41597-019-0031-8</div>.<br/>
+<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&#10;doi: 10.1038/s41597-019-0031-8</div>.<br/>
<div class="csl-left-margin">Hancké et al. 2007: </div>B. Hancké/M. Rhodes/M. Thatcher (eds.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York 2007).<br/>
<div class="csl-left-margin">Mares 2001: </div>I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall/D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York 2001) 184–213.<br/>
|
This comment has been minimized.
This comment has been minimized.
Thanks for fixing the "in-text"-issue!
Theoretically you are right. But I personally prefer to set the parentheses manually which gives you more flexibility to add information related to this citation. |
This comment has been minimized.
This comment has been minimized.
I'd rather see the parentheses here -- that's how all other such styles in CSL are implemented, so by removing that you break the ability to switch styles. |
Point taken regarding the parentheses. Additionally adjusted the meta-data.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Nov 10, 2019
Below are some sample citations generated based on your proposed changes: journal-of-neolithic-archaeology.csl (modified style)(Hancké et al. 2007; CSL search by example 2012) -Hancké et al. 2007; CSL search by example 2012<br/>
-<span style="font-variant: small-caps">Mares</span> 2001; <span style="font-variant: small-caps">Fenner et al.</span> 2019<br/>
+(Hancké et al. 2007; CSL search by example 2012)<br/>
+(Mares 2001; Fenner et al. 2019)<br/>
<hr/>
<div class="csl-left-margin">CSL search by example 2012: </div>CSL search by example, 2012<div class="csl-block">.&#10;http://editor.citationstyles.org/searchbyexample/ [December 15, 2012]</div>.<br/>
-<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&#10;<span style="font-variant: small-caps">doi: </span>10.1038/s41597-019-0031-8</div>.<br/>
+<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&#10;doi: 10.1038/s41597-019-0031-8</div>.<br/>
<div class="csl-left-margin">Hancké et al. 2007: </div>B. Hancké/M. Rhodes/M. Thatcher (eds.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York 2007).<br/>
<div class="csl-left-margin">Mares 2001: </div>I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall/D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York 2001) 184–213.<br/>
|
03306b2
into
citation-style-language:master
This comment has been minimized.
This comment has been minimized.
Thanks! |
nmueller18 commentedNov 7, 2019
The category citation-format was defined twice which led to unwished behaviour (footnotes instead of in-text citations). In the proposed branch, the incriminating line is deleted.