Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update journal-of-neolithic-archaeology.csl #4398

Merged
merged 4 commits into from Nov 12, 2019

Conversation

@nmueller18
Copy link
Contributor

nmueller18 commented Nov 7, 2019

The category citation-format was defined twice which led to unwished behaviour (footnotes instead of in-text citations). In the proposed branch, the incriminating line is deleted.

The category citation-format was defined twice which led to unwished behaviour (footnotes instead of in-text citations). In the proposed branch, the incriminating line is deleted.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 7, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 7, 2019

😟 There are some issues with your submission.

1 test failed

journal-of-neolithic-archaeology: must have a "class" attribute that matches the "citation-format" attribute

expected: "in-text"
     got: "note"

(compared using ==)

Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 8, 2019

Thanks. From a quick view of the styleguide, it'd seem like citations should also be in parentheses, right? Currently this does Smith 1776 when I think is thould be (Smith 1776)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 8, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

journal-of-neolithic-archaeology.csl (modified style; unchanged output for sample items)
Hancké et al. 2007; CSL search by example 2012
Mares 2001; Fenner et al. 2019

CSL search by example 2012:
CSL search by example, 2012
.
http://editor.citationstyles.org/searchbyexample/ [December 15, 2012]
.
Fenner et al. 2019:
M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28
.
http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]
.
doi: 10.1038/s41597-019-0031-8
.
Hancké et al. 2007:
B. Hancké/M. Rhodes/M. Thatcher (eds.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York 2007).
Mares 2001:
I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall/D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York 2001) 184–213.
Two more small changes: the in-text-names of the authors are not supposed to appear in small caps, neither the dois.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

journal-of-neolithic-archaeology.csl (modified style)
Hancké et al. 2007; CSL search by example 2012
Mares 2001; Fenner et al. 2019

CSL search by example 2012:
CSL search by example, 2012
.
http://editor.citationstyles.org/searchbyexample/ [December 15, 2012]
.
Fenner et al. 2019:
M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28
.
http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]
.
doi: 10.1038/s41597-019-0031-8
.
Hancké et al. 2007:
B. Hancké/M. Rhodes/M. Thatcher (eds.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York 2007).
Mares 2001:
I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall/D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York 2001) 184–213.
 Hancké et al. 2007; CSL search by example 2012<br/>
-<span style="font-variant: small-caps">Mares</span> 2001; <span style="font-variant: small-caps">Fenner et al.</span> 2019<br/>
+Mares 2001; Fenner et al. 2019<br/>
 <hr/>
 <div class="csl-left-margin">CSL search by example 2012: </div>CSL search by example, 2012<div class="csl-block">.&amp;#10;http://editor.citationstyles.org/searchbyexample/ [December 15, 2012]</div>.<br/>
-<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&amp;#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&amp;#10;<span style="font-variant: small-caps">doi: </span>10.1038/s41597-019-0031-8</div>.<br/>
+<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&amp;#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&amp;#10;doi: 10.1038/s41597-019-0031-8</div>.<br/>
 <div class="csl-left-margin">Hancké et al. 2007: </div>B. Hancké/M. Rhodes/M. Thatcher (eds.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York 2007).<br/>
 <div class="csl-left-margin">Mares 2001: </div>I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall/D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York 2001) 184–213.<br/>
@nmueller18

This comment has been minimized.

Copy link
Contributor Author

nmueller18 commented Nov 9, 2019

Thanks for fixing the "in-text"-issue!

Thanks. From a quick view of the styleguide, it'd seem like citations should also be in parentheses, right? Currently this does Smith 1776 when I think is thould be (Smith 1776)

Theoretically you are right. But I personally prefer to set the parentheses manually which gives you more flexibility to add information related to this citation.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 10, 2019

I'd rather see the parentheses here -- that's how all other such styles in CSL are implemented, so by removing that you break the ability to switch styles.
You can obviously use a custom version without parentheses for your own purposes. Otherwise this is good to merge.

Point taken regarding the parentheses. Additionally adjusted the meta-data.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 10, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

journal-of-neolithic-archaeology.csl (modified style)
(Hancké et al. 2007; CSL search by example 2012)
(Mares 2001; Fenner et al. 2019)

CSL search by example 2012:
CSL search by example, 2012
.&#10;http://editor.citationstyles.org/searchbyexample/ [December 15, 2012]
.
Fenner et al. 2019:
M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28
.&#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]
.&#10;doi: 10.1038/s41597-019-0031-8
.
Hancké et al. 2007:
B. Hancké/M. Rhodes/M. Thatcher (eds.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York 2007).
Mares 2001:
I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall/D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York 2001) 184–213.
-Hancké et al. 2007; CSL search by example 2012<br/>
-<span style="font-variant: small-caps">Mares</span> 2001; <span style="font-variant: small-caps">Fenner et al.</span> 2019<br/>
+(Hancké et al. 2007; CSL search by example 2012)<br/>
+(Mares 2001; Fenner et al. 2019)<br/>
 <hr/>
 <div class="csl-left-margin">CSL search by example 2012: </div>CSL search by example, 2012<div class="csl-block">.&amp;#10;http://editor.citationstyles.org/searchbyexample/ [December 15, 2012]</div>.<br/>
-<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&amp;#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&amp;#10;<span style="font-variant: small-caps">doi: </span>10.1038/s41597-019-0031-8</div>.<br/>
+<div class="csl-left-margin">Fenner et al. 2019: </div>M. Fenner/M. Crosas/J. S. Grethe/D. Kennedy/H. Hermjakob/P. Rocca-Serra/G. Durand/R. Berjon/S. Karcher/M. Martone/T. Clark, A data citation roadmap for scholarly data repositories. Scientific Data 6, 1, 2019, 28<div class="csl-block">.&amp;#10;http://www.nature.com/articles/s41597-019-0031-8 [April 27, 2019]</div><div class="csl-block">.&amp;#10;doi: 10.1038/s41597-019-0031-8</div>.<br/>
 <div class="csl-left-margin">Hancké et al. 2007: </div>B. Hancké/M. Rhodes/M. Thatcher (eds.), Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York 2007).<br/>
 <div class="csl-left-margin">Mares 2001: </div>I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall/D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York 2001) 184–213.<br/>
@adam3smith adam3smith merged commit 03306b2 into citation-style-language:master Nov 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.