Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutrition Research Reviews #4428

Closed

Conversation

@justintondt
Copy link
Contributor

justintondt commented Dec 1, 2019

Vancouver style modified for parenthetical superscript and et al after 3 authors

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 1, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 1, 2019

😟 There are some issues with your submission.

2 tests failed

vancouver-superscript-brackets-only-year: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/vancouver-superscript-brackets-only-year"
     got: "http://www.zotero.org/styles/nutrition-research-reviews"

(compared using ==)

vancouver-superscript-brackets-only-year: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (3) to be greater than et-al-use-first (3)

Please check the test report for details.

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Dec 2, 2019

Hi,
Thank you for submitting a style.
Unfortunately, you are trying to overwrite the generic vancouver style, which is not what we'd want here.
Can you make a new Pull Request following the steps outlined here? "New file" is the keyword. ;)
https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md

justintondt added a commit to justintondt/styles that referenced this pull request Dec 3, 2019
…ge#4429

Vancouver modified for parenthetical superscripts and et al. after 3 authors
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Dec 7, 2019

superseded by #4434

@adam3smith adam3smith closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.