Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutrition Research Reviews #4429

Closed
wants to merge 3 commits into from
+240 −0

Conversation

@justintondt
Copy link
Contributor

justintondt commented Dec 2, 2019

Vancouver modified for parenthetical superscripts and et al. after 3 authors
@justintondt
Nutrition Research Reviews
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fcca0c9 
Vancouver modified for parenthetical superscripts and et al. after 3 authors
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Dec 2, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Dec 2, 2019

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/dependent/nutrition-research-reviews"]

(compared using ==)

Please check the test report for details.
@justintondt
Rename nutrition-research-reviews to nutrition-research-reviews.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7302632
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Dec 2, 2019

😟 There are some issues with your submission.

5 tests failed

dependent/nutrition-research-reviews: must be a dependent style (independent styles must be placed in the root directory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" default-locale="en...t="minimal" demote-non-dropping-particle="sort-only" et-al-min="3" et-al-use-first="3" children=[5]>.dependent?` to return true, got nil

dependent/nutrition-research-reviews: "independent-parent" link must point to an existing independent style

expected nil to match /^http:\/\/www.zotero.org\/styles\//

dependent/nutrition-research-reviews: may not have <macro/>, <citation/>, or <bibliography/> elements

expected #has_macro? to return false, got true

dependent/nutrition-research-reviews: may not have a "template" link

expected #has_template_link? to return false, got true

dependent/nutrition-research-reviews: must have the same citation-format as its independent-parent

undefined method `[]' for nil:NilClass

Please check the test report for details.
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Dec 3, 2019

Continued from: #4428
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Dec 3, 2019

Issues:

  1. Filename: currently you have the file in the "dependent" folder. This is an independent style, so you can put it in the main folder by just deleting the "dependent/" part of the filename.
  2. Please add a link to the documentation after line 8. (as lined out here: https://github.com/citation-style-language/styles/wiki/Style-Requirements)
@justintondt
Update nutrition-research-reviews.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3280792
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Dec 3, 2019

😟 There are some issues with your submission.

5 tests failed

dependent/nutrition-research-reviews: must be a dependent style (independent styles must be placed in the root directory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" default-locale="en...t="minimal" demote-non-dropping-particle="sort-only" et-al-min="3" et-al-use-first="3" children=[5]>.dependent?` to return true, got nil

dependent/nutrition-research-reviews: "independent-parent" link must point to an existing independent style

expected nil to match /^http:\/\/www.zotero.org\/styles\//

dependent/nutrition-research-reviews: may not have <macro/>, <citation/>, or <bibliography/> elements

expected #has_macro? to return false, got true

dependent/nutrition-research-reviews: may not have a "template" link

expected #has_template_link? to return false, got true

dependent/nutrition-research-reviews: must have the same citation-format as its independent-parent

undefined method `[]' for nil:NilClass

Please check the test report for details.
justintondt added a commit to justintondt/styles that referenced this pull request Dec 3, 2019
@justintondt
Continued from citation-style-language#4428 and citation-style-langua…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
63e4711 
…ge#4429

Vancouver modified for parenthetical superscripts and et al. after 3 authors
@justintondt justintondt mentioned this pull request Dec 3, 2019
Merged
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Dec 7, 2019

superseded by #4434
@adam3smith adam3smith closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@justintondt @csl-bot @POBrien333 @adam3smith
You can’t perform that action at this time.