[PRE REVIEW]: pyHoops: A Python package for advanced basketball data analytics #1784

whedon · 2019-10-04T16:12:06Z

Submitting author: @alessandroBombelli (Alessandro Bombelli)
Repository: https://github.com/alessandroBombelli/pyHoops
Version: v1.5
Editor: @danielskatz
Reviewers: @mado89, @ctsilva

Author instructions

Thanks for submitting your paper to JOSS @alessandroBombelli. Currently, there isn't an JOSS editor assigned to your paper.

@alessandroBombelli if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

whedon · 2019-10-04T16:12:09Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon · 2019-10-04T16:12:10Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-10-04T16:12:17Z

Failed to discover a valid open source license.

whedon · 2019-10-04T16:12:22Z

PDF failed to compile for issue #1784 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon.rb:135:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon.rb:87:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

kyleniemeyer · 2019-10-04T16:14:44Z

Hello @alessandroBombelli, thanks for your interest in JOSS. Before we proceed, during my review of your submission, I could not find the research application of your software. While useful for folks in basketball, I don't quite see where someone would cite this in the academic literature (not an explicit requirement, but one way we think about whether software has a research use).

Can you clarify this, per one of our submission requirements?

The software should have an obvious research application.

danielskatz · 2019-10-04T16:26:04Z

alessandroBombelli/pyHoops#46 should fix the immediate paper building process

alessandroBombelli · 2019-10-04T16:57:55Z

Hello @alessandroBombelli, thanks for your interest in JOSS. Before we proceed, during my review of your submission, I could not find the research application of your software. While useful for folks in basketball, I don't quite see where someone would cite this in the academic literature (not an explicit requirement, but one way we think about whether software has a research use).

Can you clarify this, per one of our submission requirements?

The software should have an obvious research application.

Dear @kyleniemeyer, apologies if the research application is not clear. I agree that, at a first glance, the obvious research application might not be as straight-forward as in other cases. On the other hand, a strong interest in data analytics applied to sports has been growing in recent years, as testified by ad-hoc conferences (MIT Sloan Sports Analytics Conference) and journals (Journal of Sports Sciences). To this avail, the research application of this work is the possibility to compute a set of team performance indices (per player and per lineup) to be used, as example, to infer lineup performances in future games. Knowing how different lineups perform against different opposing lineups (e.g., "tall", or "fast" lineups), can be used as part of a decision-making process to improve performances of a team. In addition, a sufficiently comprehensive database retrieved via pyHoops (e.g., a full season), can be used as the input for a prediction model (e.g., random forest) to assess what are the features (lineup- or player-specific) more crucial for a team's success. I hope this answers your question. I am willing to elaborate more if the answer is not satisfactory. Thank you!

danielskatz · 2019-10-04T17:06:21Z

I can take

alessandroBombelli · 2019-10-04T17:22:08Z

alessandroBombelli/pyHoops#46 should fix the immediate paper building process

Dear @danielskatz, sorry for the issue. but it is my first time here and, as such, I am not familiar with the formatting. I followed the example provided in the guidelines but thought that, being a single author, the distinction between affiliation and affiliations was not necessary. I fixed the issue now. Please let me know otherwise.
Thank you very much

kyleniemeyer · 2019-10-04T17:49:05Z

@danielskatz thanks for volunteering—did you mean to close the issue?

kyleniemeyer · 2019-10-04T17:50:47Z

@alessandroBombelli ok, so I think it would help to revise your article to better describe the research applications of the software, so this is clear to reviewers (and readers), focusing specifically on the types of research questions/problems this helps answer.

What you are describing to me sounds more like what a basketball team might use, but not an academic researcher writing a publication (for example)—but I may still be misunderstanding.

danielskatz · 2019-10-04T19:08:40Z

@whedon generate pdf

whedon · 2019-10-04T19:08:42Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-10-04T19:09:11Z

👉 Check article proof 📄 👈

danielskatz · 2019-10-04T19:26:52Z

I've suggested more changes in alessandroBombelli/pyHoops#48 - after merging this, you can enter @whedon generate pdf as a new comment here to regenerate the paper.

kyleniemeyer · 2019-10-04T19:29:53Z

@whedon assign @danielskatz as editor

whedon · 2019-10-04T19:29:57Z

OK, the editor is @danielskatz

danielskatz · 2019-10-07T16:45:16Z

@alessandroBombelli - do you have suggestions for reviewers? They can be from this list of potential reviewers (please start at the bottom of the list), or individuals who are not on this list; if so, please mention their GitHub handles here.

alessandroBombelli · 2019-10-08T15:17:11Z

@whedon generate pdf

whedon · 2019-10-08T15:17:13Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-10-08T15:17:48Z

👉 Check article proof 📄 👈

alessandroBombelli · 2019-10-08T15:18:10Z

I've suggested more changes in alessandroBombelli/pyHoops#48 - after merging this, you can enter @whedon generate pdf as a new comment here to regenerate the paper.

@danielskatz, I slightly modified references because I realized two of them were not correctly compiled. In one case, there was a @ missing. In the other case, where I am citing a website, I am not sure what the problem is. I am using the same citation type I would use in a classic LaTeX file, where I know it should work. On the other hand, I am not very familiar with the integration of the .md file with the .bib file, so I have little control on what is going wrong. Could you please help me with that? Thanks!

alessandroBombelli · 2019-10-08T15:19:17Z

I've suggested more changes in alessandroBombelli/pyHoops#48 - after merging this, you can enter @whedon generate pdf as a new comment here to regenerate the paper.

@danielskatz, I slightly modified references because I realized two of them were not correctly compiled. In one case, there was a @ missing. In the other case, where I am citing a website, I am not sure what the problem is. I am using the same citation type I would use in a classic LaTeX file, where I know it should work. On the other hand, I am not very familiar with the integration of the .md file with the .bib file, so I have little control on what is going wrong. Could you please help me with that? Thanks!

@danielskatz never mind, it is fixed now. Sorry for the confusion

whedon · 2019-10-08T15:41:53Z

OK, the reviewer is @mado89

alessandroBombelli · 2019-10-08T15:46:50Z

@whedon generate pdf

whedon · 2019-10-08T15:46:52Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-10-08T15:47:22Z

PDF failed to compile for issue #1784 with the following error:

Error reading bibliography ./pyHoops_references.bib (line 18, column 3):
unexpected "p"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

alessandroBombelli · 2019-10-08T15:48:35Z

@whedon generate pdf

whedon · 2019-10-08T15:48:37Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-10-08T15:49:01Z

👉 Check article proof 📄 👈

alessandroBombelli · 2019-10-08T15:50:45Z

@whedon generate pdf

whedon · 2019-10-08T15:50:47Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-10-08T15:51:21Z

👉 Check article proof 📄 👈

alessandroBombelli · 2019-10-08T15:54:07Z

Also, for @Travassos, please add the DOI (https://doi.org/10.1080/24748668.2013.11868633)

@danielskatz done!

danielskatz · 2019-10-24T09:16:25Z

As a quick update, I am still working on finding another review, partially by private email. Any more suggestions are also welcome.

mado89 · 2019-10-24T18:19:06Z

What are the requirements for the reviewer? I might know a guy who knows somebody working in the industry (sport data)Sent from my mobile devicePlease excuse briefness and typos

…

-------- Original message -------- From: "Daniel S. Katz" <notifications@github.com> Date: 24/10/2019 11:16 (GMT+01:00) To: openjournals/joss-reviews <joss-reviews@noreply.github.com> Cc: Martin Dobiasch <martin.dobiasch@dobibrennda.at>, Mention <mention@noreply.github.com> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: pyHoops: A Python   package for advanced basketball data analytics (#1784) As a quick update, I am still working on finding another review, partially by private email. Any more suggestions are also welcome. —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#1784?email_source=notifications\u0026email_token=AAHOFCO7TNDWDOR2SCXLWPTQQFRX7A5CNFSM4I5RXDO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEKQMI#issuecomment-545826865", "url": "#1784?email_source=notifications\u0026email_token=AAHOFCO7TNDWDOR2SCXLWPTQQFRX7A5CNFSM4I5RXDO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEKQMI#issuecomment-545826865", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

danielskatz · 2019-10-27T17:31:29Z

The reviewer should be familiar with open source, ideally with the domain and language of the software, and should not be conflicted with the authors

danielskatz · 2019-10-30T06:38:43Z

👋 @ctsilva - thanks for agreeing by email to review

danielskatz · 2019-10-30T06:38:53Z

@whedon add @ctsilva as reviewer

whedon · 2019-10-30T06:38:57Z

OK, @ctsilva is now a reviewer

danielskatz · 2019-10-30T06:39:26Z

@whedon start review

whedon · 2019-10-30T06:39:30Z

OK, I've started the review over in #1845. Feel free to close this issue now!

alessandroBombelli · 2019-10-30T12:36:03Z

As a quick update, I am still working on finding another review, partially by private email. Any more suggestions are also welcome.

Dear @danielskatz sorry for the late reply. Thanks for the efforts in finding suitable reviewers. I really appreciated

whedon added the pre-review label Oct 4, 2019

whedon added Jupyter Notebook Python TeX labels Oct 4, 2019

danielskatz closed this Oct 4, 2019

danielskatz reopened this Oct 4, 2019

whedon assigned danielskatz Oct 4, 2019

whedon assigned danielskatz and mado89 and unassigned danielskatz Oct 8, 2019

whedon unassigned mado89 and danielskatz Oct 30, 2019

whedon assigned danielskatz and mado89 Oct 30, 2019

danielskatz closed this Oct 30, 2019

danielskatz reopened this Nov 6, 2019

danielskatz closed this Nov 6, 2019

Please note that GitHub no longer supports your web browser.

Sponsor openjournals/joss-reviews

openjournals/joss-reviews

Join GitHub today

[PRE REVIEW]: pyHoops: A Python package for advanced basketball data analytics #1784

Comments

whedon commented Oct 4, 2019 • edited

This comment has been minimized.

whedon commented Oct 4, 2019

This comment has been minimized.

whedon commented Oct 4, 2019

This comment has been minimized.

whedon commented Oct 4, 2019

This comment has been minimized.

whedon commented Oct 4, 2019

This comment has been minimized.

kyleniemeyer commented Oct 4, 2019

This comment has been minimized.

danielskatz commented Oct 4, 2019

This comment has been minimized.

alessandroBombelli commented Oct 4, 2019

This comment has been minimized.

danielskatz commented Oct 4, 2019

This comment has been minimized.

alessandroBombelli commented Oct 4, 2019

This comment has been minimized.

kyleniemeyer commented Oct 4, 2019

This comment has been minimized.

kyleniemeyer commented Oct 4, 2019

This comment has been minimized.

danielskatz commented Oct 4, 2019

This comment has been minimized.

whedon commented Oct 4, 2019

This comment has been minimized.

whedon commented Oct 4, 2019

This comment has been minimized.

danielskatz commented Oct 4, 2019

This comment has been minimized.

kyleniemeyer commented Oct 4, 2019

This comment has been minimized.

whedon commented Oct 4, 2019

This comment has been minimized.

danielskatz commented Oct 7, 2019

This comment has been minimized.

alessandroBombelli commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

alessandroBombelli commented Oct 8, 2019

This comment has been minimized.

alessandroBombelli commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

alessandroBombelli commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

alessandroBombelli commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

alessandroBombelli commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

whedon commented Oct 8, 2019

This comment has been minimized.

alessandroBombelli commented Oct 8, 2019

This comment has been minimized.

danielskatz commented Oct 24, 2019

This comment has been minimized.

mado89 commented Oct 24, 2019

This comment has been minimized.

whedon commented Oct 4, 2019 •

edited