Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: perccalc: An R package for estimating percentiles from categorical variables #1796
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @briatte, @amoeba it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BTW, @briatte, thanks for volunteering to review! (I took you at your word...) |
This comment has been minimized.
This comment has been minimized.
@majensen No problem. I'm planning to review the package next week, probably Thursday or Friday. |
This comment has been minimized.
This comment has been minimized.
Hey @majensen, @cimentadaj, I've conducted my first pass at the review checklist and things look very good overall. I have some items I'd like @cimentadaj to address so at this point my review is a conditional accept. See: cimentadaj/perccalc#2. |
This comment has been minimized.
This comment has been minimized.
Hi @majensen, @cimentadaj and @amoeba I'm also done with my review: conditional accept with very minor revisions, some of which are nitpicky to the point that @cimentadaj might reasonably decide to ignore them entirely. @amoeba -- There's a small risk that I might have accidentally checked one item on your review list. I'm very sorry for that -- please accept my apologies: I'm still learning to do JOSS reviews, plus it was early morning and I had had only one coffee (this has been fixed since). |
This comment has been minimized.
This comment has been minimized.
Hi everyone Thanks for the reviews. I'm probably gonna check them out first week of November and finish them at that time. Is that good? |
This comment has been minimized.
This comment has been minimized.
@cimentadaj sounds good to me. That accords with my schedule too :D |
This comment has been minimized.
This comment has been minimized.
I've answered to all comments from both reviewers here. As I outlined there, I'm happy to review some points if they feel like their points weren't addressed. Thank you both for reviewing the paper/package, the comments have been very helpful to ship the next version to CRAN flawlessly! |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@briatte, @amoeba -- based on @cimentadaj comments at issue 2, are you guys prepared to check off the remaining boxes? |
This comment has been minimized.
This comment has been minimized.
@majensen, we're almost there. Still elucidating whether we keep/remove the example section. I think we'll have this figured out by the end of the week. |
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@majensen my review is now an Accept after @cimentadaj 's recent change to the paper, removing the examples, as per cimentadaj/perccalc#2 (comment). |
This comment has been minimized.
This comment has been minimized.
Same here, I'm also Accept at that stage. |
This comment has been minimized.
This comment has been minimized.
@amoeba and @briatte thanks very much; and thanks @cimentadaj for your hard work and responsiveness. I will perform my final proofreading tasks - might lead to a PR - and then will make the formal recommendation. |
This comment has been minimized.
This comment has been minimized.
(right after @cimentadaj merges the review branch...) |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Thanks @danielskatz, should be fixed now for the van Buuren paper and the Agresti book. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
There are a number of other small changes, which I've suggested fixes for in cimentadaj/perccalc#8 - please merge, or let me know which you disagree with. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey @briatte, sorry, we need you to check off the rest of the boxes on your review - thanks |
This comment has been minimized.
This comment has been minimized.
@danielskatz : My guess is @briatte is OOO, since he is usu. very responsive. In view of comment from @briatte 's comment at #1796 (comment) and previous, I would recommend moving forward with the publication. |
This comment has been minimized.
This comment has been minimized.
If you are sure this is ok, please check the missing box for @briatte, then let me know, and I will do the further processing in the next 24 hours. |
This comment has been minimized.
This comment has been minimized.
@danielskatz boxes checked thanks |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1164, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
Thanks to @briatte and @amoeba for reviewing and @majensen for editing! |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedOct 10, 2019
•
edited by majensen
Submitting author: @cimentadaj (Jorge Cimentada)
Repository: https://github.com/cimentadaj/perccalc/
Version: v1.0.5
Editor: @majensen
Reviewer: @briatte, @amoeba
Archive: 10.5281/zenodo.3559855
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@briatte & @amoeba, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @majensen know.
Review checklist for @briatte
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @amoeba
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper