Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BibTeX citekey more rigorously in the future #2072

Open
wants to merge 1 commit into
base: master
from

Conversation

@zuphilip
Copy link
Collaborator

zuphilip commented Nov 30, 2019

This superseeds #1013.
@zuphilip zuphilip changed the title Clean BibTeX citekey more rigourosly in the future Clean BibTeX citekey more rigorously in the future Nov 30, 2019
@zuphilip zuphilip requested a review from adam3smith Nov 30, 2019
@zuphilip
Clean BibTeX citekey more rigourosly in the future
Loading status checks…
4cada1b 
This superseeds #1013.
@zuphilip zuphilip force-pushed the zuphilip:bibtex-citekey branch from e2dcf33 to 4cada1b Dec 7, 2019
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Dec 9, 2019

oh, that's clever, I like this solution.
Would you be up for also linting the translator or is that totally gruesome? If not, OK to merge from my end.
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Dec 9, 2019

I don't want to fix linting issues as long as there are other open PR for BibTeX translator, e.g. #1937, #1073, #2028 (also that is more there as an issue). Okay?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
You can’t perform that action at this time.