Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSetup Docker for notebooks #8
Conversation
ruebot
force-pushed the
docker
branch
from
f68ae87
to
79b9455
Mar 1, 2019
ruebot
requested review from
ianmilligan1
,
greebie
and
SamFritz
Mar 1, 2019
This comment has been minimized.
This comment has been minimized.
I haven't added this into the README yet, but if you want to include your own data or notebooks: Just data:
Just notebook(s)
Both:
Figured we can wait on incorporating this. I'd like us to consider removing one of the two notebooks we have now. Then replace it with a notebook that has the data variables blank (maybe this is the middle step to the |
This comment has been minimized.
This comment has been minimized.
Great, thanks @ruebot – this looks awesome (I got to see a sneak peak of it in real life over Nick's shoulder this afternoon). I will probably test this on Monday (or this weekend if I can find a moment, but probably Monday). I think a notebook that has the data variables blank makes sense to me, but curious to hear @greebie's thoughts as the repo's original architect. |
This comment has been minimized.
This comment has been minimized.
I agree with removing the second notebook. The only reason it was there in the first place was to show the community what it looked like without having to clone and run Jupyter. It has no other purpose. I also agree the next step is to include some kind of markup for the things we want variable in auk. Collection is obvious, but I also things like the data folder, descriptive information (title, organization, etc. if possible) and maybe even consider a partner logo. |
This comment has been minimized.
This comment has been minimized.
Only question in my mind is whether to remove ggplot from the dep list. I saw you added the hack, so I'm fine with keeping it. The only advantage is that the ggplot graphs etc. are more pretty than matplotlib. None of the scripts use ggplot as it stands. |
ruebot
force-pushed the
docker
branch
from
79b9455
to
a8626fb
Mar 2, 2019
This comment has been minimized.
This comment has been minimized.
Let’s keep things as simple as we can, in case our WASAPI partners ever increase. I’d be inclined to avoid things like partner logos, etc. and just keep to collection ID and perhaps collection title. |
ruebot commentedMar 1, 2019
•
edited
Test: