Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade blacklight to version 7.1.0 #83
Conversation
depfu
bot
added
the
depfu
label
Sep 13, 2019
ruebot
merged commit 6b96fc1
into
master
Sep 20, 2019
1 check passed
depfu
bot
deleted the
depfu/update/blacklight-7.1.0
branch
Sep 20, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Sep 20, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedSep 13, 2019
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Commits
See the full diff on Github. The new version differs by 69 commits:
adjusts search result bookmark, thumbnail padding (#2125)
Merge pull request #2131 from labradford/checkbox-toggle-js-use-html
update text method to use html for checkbox label toggle
Upgrade TravisCI distro to bionic
Merge pull request #2120 from projectblacklight/functional
Merge pull request #2126 from labradford/arclight-616-screenreader-duplicate-search
pr feedback for backwards compatibility
ability to add aria-hidden to blacklight icon
adjusts search result bookmark, thumbnail padding
Merge pull request #2121 from projectblacklight/lodash
Update javascript packages
Make render_document_sidebar_partial functional
Merge pull request #2122 from projectblacklight/update-rubocop-rspec
Update rubocop-rspec
Merge pull request #2119 from dunn/emails
RecordMailer: remove array syntax from record title
RecordMailer: add whitespace between records
Merge pull request #2111 from cdmo/namespace-qualifier
Merge pull request #2116 from projectblacklight/merging-criteria
Add explicit criteria for merging PRs
Fix up link syntax and replace dead link
Port 'Contributing to Blacklight' wiki page to a CONTRIBUTING.md
Update jquery to 3.4 to avoid CVE-2019-11358
Merge pull request #2113 from projectblacklight/correct_bootstrap4_accordion
Add aria-labelledby to facet body, pointing to new id added to facet header
Match bootstrap4 accordion example, avoids 'jankiness' on facet open/close
Adding the Blacklight namespace to these helper behaviors
Merge pull request #2110 from projectblacklight/default_capybara_driver_def
Use capybara :selenium_chrome_headless built-in driver definition
Merge pull request #2109 from cdmo/patch-2
Obsolete documentation?
Merge pull request #2108 from projectblacklight/version_7_1_0
mark 7.1.0 for release
Merge pull request #2101 from cdmo/patch-1
Merge pull request #2103 from projectblacklight/mejackreed-patch-1
Merge pull request #2102 from projectblacklight/webdrivers
Remove EOL'd 2.3.8
Rely on webdrivers to do its magic
Use webdrivers in place of chromedriver-helper
Use bg-light
Merge pull request #2094 from projectblacklight/remove_popper_js_generated
No need to generate popper_js into Gemfile
support multiple flash messages of each type
Update Chromedriver
Merge pull request #2089 from projectblacklight/fix_field
Fix a field name for author in the example schema
Merge pull request #2076 from projectblacklight/without_nokogiri
Remove generator that no longer does anything
Test on Xenial Xerus + openjdk11
Group facets into separate blocks based upon group specified on facet field in config
Merge pull request #2075 from projectblacklight/search-service-controller-context
Split out Blacklight::Searchable concern with search service-related methods
Allow the implementor to supply context information to the search service, which restores functional compatibility with Blacklight 6 search builders.
Merge pull request #2079 from projectblacklight/present
Merge pull request #2080 from projectblacklight/hash
👋 #️⃣ 🚀
Prefer if over unless. present? over !blank?
Merge pull request #2071 from projectblacklight/track-search-session
Drop Nokogiri as a required dependency
Update the front-end package to use bootstrap 4.3.1
Fix pagination breaks on small screens
Add explicit configuration to enable search session tracking
Merge pull request #2069 from projectblacklight/avoid-nme
Avoid NoMethodError
Upgrade to rubocop 0.63.0
Merge pull request #2063 from danschmidt5189/2062-delete_old_searches_in_batches
Improve Search.delete_old_searches performance by not loading relations
There's no need for us to update rubygems and bundler at this time
Update bootstrap dependency to 4.2 for the npm package
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands