Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator for Library Hub Discover search results #2082

Open
wants to merge 4 commits into
base: master
from

Conversation

@placardo
Copy link
Contributor

placardo commented Dec 10, 2019

Fix #1986. This is really just a wrapper for COinS on the search results (I'm not sure how useful this is or if it is good practice to make such a limited translator - does it slow the connector's loading?). In any case I added https://discover.libraryhub.jisc.ac.uk/search?q=test as a test and it works fine, COins works seamlessly on individual items (NB: this was noted on the original issue https://forums.zotero.org/discussion/78478/library-hub-discover-replacing-copac-is-there-a-zotero-translator#latest)

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Dec 10, 2019

I think we'll actually want to check if we can do better than COinS (which is a very limited format). I suspect we can, e.g. using the provided MODS

@placardo

This comment has been minimized.

Copy link
Contributor Author

placardo commented Dec 10, 2019

Do you have some kind of reference on the hierarchy between formats? This would be useful
Indeed they seem to have XML endpoints (https://discover.libraryhub.jisc.ac.uk/support/api/) I suppose I can feed this to MODS.js in the same way as the SAGE Journals translator fed it to the RIS translator?

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Dec 10, 2019

Do you have some kind of reference on the hierarchy between formats? This would be useful

Not a reference but broadly:

  1. MARC/MARCXML and MODS
  2. Rich custom formats (like PNX for Primo) but those are a lot of work
  3. RIS / BibTeX (both have pros and cons, depends on implementation)
  4. Embedded Metadata of high quality (e.g. complete highwire tags)
  5. COinS
  6. Embedded Metadata of low quality (e.g. basic DC)

Indeed they seem to have XML endpoints (https://discover.libraryhub.jisc.ac.uk/support/api/) I suppose I can feed this to MODS.js in the same way as the SAGE Journals translator fed it to the RIS translator?

Should work exactly the same, yes.

placardo added 2 commits Dec 11, 2019
@placardo

This comment has been minimized.

Copy link
Contributor Author

placardo commented Dec 11, 2019

I tried to implement it using the MODS endpoints but this is really not satisfactory, because the type is rarely well detected. Eg this item which is obviously a feature film, is detected by MODS as a "video recording", COinS thinks everything is a book and RIS / Bibtex find the right "film" type, but I did not find any unambiguous element on the page to detect the right type (the schema information is "CreativeWork" and the Library Hub info is "visual", which is shared with a lot of categories).
It does work well for some items eg sound recordings or maps where the ambiguity is reduced. I'm not sure how to proceed forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.