Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTranslator for Library Hub Discover search results #2082
Conversation
This comment has been minimized.
This comment has been minimized.
I think we'll actually want to check if we can do better than COinS (which is a very limited format). I suspect we can, e.g. using the provided MODS |
This comment has been minimized.
This comment has been minimized.
Do you have some kind of reference on the hierarchy between formats? This would be useful |
This comment has been minimized.
This comment has been minimized.
Not a reference but broadly:
Should work exactly the same, yes. |
This comment has been minimized.
This comment has been minimized.
I tried to implement it using the MODS endpoints but this is really not satisfactory, because the type is rarely well detected. Eg this item which is obviously a feature film, is detected by MODS as a "video recording", COinS thinks everything is a book and RIS / Bibtex find the right "film" type, but I did not find any unambiguous element on the page to detect the right type (the schema information is "CreativeWork" and the Library Hub info is "visual", which is shared with a lot of categories). |
placardo commentedDec 10, 2019
•
edited
Fix #1986. This is really just a wrapper for COinS on the search results (I'm not sure how useful this is or if it is good practice to make such a limited translator - does it slow the connector's loading?). In any case I added https://discover.libraryhub.jisc.ac.uk/search?q=test as a test and it works fine, COins works seamlessly on individual items (NB: this was noted on the original issue https://forums.zotero.org/discussion/78478/library-hub-discover-replacing-copac-is-there-a-zotero-translator#latest)