Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix and improve BibTeX parsing #2020
Conversation
- In some cases the rawValue was undefined which caused a problem in the author field. - Handle electronic as webpage - Skip preamble - Improve inline documentation
See also http://www.bibtex.org/Format/
|
I tested this with the long bibtex test file from https://github.com/citation-js/bibtex-parser-experiments/blob/master/test/files/long.bib and everything worked well. Now, we are importing all 3345 entries and not other side effect was detected during the import. I will merge this the next days, if no one objects. |
Moreover, allow special characters like colon or underscore to be part of the string name.
This comment has been minimized.
This comment has been minimized.
|
This looks good to me, but leaving for you to merge, not having read the code closely enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedOct 12, 2019
a problem in the author field.