Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type edits #11

Closed
Closed

Conversation

@TrashBirdEcology
Copy link

TrashBirdEcology commented Dec 31, 2019

  • Add manual reference (using sup)
  • Minor language fixes
  • Minor type edits
  • Remove sentence
- Add manual reference (using sup)
- Minor language fixes
- Minor type edits
- Remove sentence
@danielskatz

This comment has been minimized.

Copy link
Owner

danielskatz commented Jan 7, 2020

@TrashBirdEcology - thanks for these suggestions, but I don't want to hide the fact that I'm not sure if there's an earlier reference. And I would like to keep the other sentence that I feel invites people to do more with this. So I'm going to not merge this, but again, I appreciate that you took the time to make these suggestions. I'm not completely sure what the "Minor language fixes" and "Minor type edits" you made were, as the diff isn't clear, but feel free to make such suggestions.

@danielskatz danielskatz closed this Jan 7, 2020
@TrashBirdEcology

This comment has been minimized.

Copy link
Author

TrashBirdEcology commented Jan 8, 2020

doesn't bother me. here is the diff, fyi

@danielskatz

This comment has been minimized.

Copy link
Owner

danielskatz commented Jan 8, 2020

Yeah, but the long lines make the specific diffs not appear, just the lines that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.