Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: WulffPack: A Python package for Wulff constructions #1944
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @EduPH, @mzszym, @corybrunson it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1944 with the following error: Can't find any papers to compile :-( |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf from branch joss-pape |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1944 with the following error: error: pathspec 'joss-pape' did not match any file(s) known to git. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf from branch joss-paper |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf from branch joss-paper |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thank you, @mzszym! The comparison to other packages was indeed very short. It is updated (and the missing reference has been fixed) in the latest version of the paper, like so:
|
This comment has been minimized.
This comment has been minimized.
@magnusrahm Well done. I am confident that the package fulfills all requirements. |
This comment has been minimized.
This comment has been minimized.
I will be checking GitHub in a limited capacity over the next couple of weeks. |
This comment has been minimized.
This comment has been minimized.
@drvinceknight and @magnusrahm thank you for your patience. I'm beginning my review now. |
This comment has been minimized.
This comment has been minimized.
@magnusrahm thank you for the elegant software and thorough documentation behind this submission. In most respects i think it quite meets the needs of JOSS, and the few issues i've raised should be quick to resolve. I had no problems along the way other than those raised in the issues. The concepts are quite new to me, but i hope that i've grasped them well enough to give useful feedback. I'll be quick to respond to any questions about it, and i'll check off the remaining items as the issues are addressed. |
This comment has been minimized.
This comment has been minimized.
I agree with the other two reviewers. The package fulfils all the requirements. |
This comment has been minimized.
This comment has been minimized.
(Me closing the issue was a miss click) Thank you very much for your work reviewing @EduPH, @mzszym, @corybrunson! I'll be looking through this later today with any final minor editorial requests |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon check references from branch joss-paper |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@magnusrahm everything looks good to me, would you be able to make a Zenodo archive, and report the DOI in the review thread (here). Could you make sure the Zenodo deposit has the correct metadata (title and author list should match the paper). |
This comment has been minimized.
This comment has been minimized.
@drvinceknight I have uploaded a Zenodo archive (10.5281/zenodo.3600252, https://doi.org/10.5281/zenodo.3600252). I have also merged the joss-paper branch into the master branch and deleted the former. Some very minor additions were made to the paper (https://gitlab.com/materials-modeling/wulffpack/commit/82b4e1771798733a6022ff292982bc17ea7b6310). |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.3600252 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3600252 is the archive. |
This comment has been minimized.
This comment has been minimized.
@openjournals/joss-eics this paper is ready to be accepted |
This comment has been minimized.
This comment has been minimized.
@magnusrahm - it looks like this is now version 1.1 - correct? |
This comment has been minimized.
This comment has been minimized.
Yes, that's correct. |
This comment has been minimized.
This comment has been minimized.
@whedon set v1.1 as version |
This comment has been minimized.
This comment has been minimized.
OK. v1.1 is the version. |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1205, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
Thanks to @EduPH, @mzszym, @corybrunson for reviewing! |
This comment has been minimized.
This comment has been minimized.
I'm now waiting for the DOI to resolve, after which I will close this issue |
This comment has been minimized.
This comment has been minimized.
Thank you! |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedDec 12, 2019
•
edited
Submitting author: @magnusrahm (Magnus Rahm)
Repository: https://gitlab.com/materials-modeling/wulffpack
Version: v1.1
Editor: @drvinceknight
Reviewer: @EduPH, @mzszym, @corybrunson
Archive: 10.5281/zenodo.3600252
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@EduPH & @mzszym & @corybrunson, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @drvinceknight know.
Review checklist for @EduPH
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @mzszym
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @corybrunson
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper