Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Phobos: A tool for creating complex robot models #1254

Open
whedon opened this Issue Feb 15, 2019 · 20 comments

Comments

Projects
None yet
5 participants
@whedon
Copy link
Collaborator

whedon commented Feb 15, 2019

Submitting author: @Amudtogal (Simon Reichel)
Repository: https://github.com/dfki-ric/phobos
Version: 1.0.0 "Capricious Choutengan"
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @Amudtogal. The JOSS editor Pending, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@Amudtogal if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Feb 15, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Feb 15, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Feb 15, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Feb 15, 2019

PDF failed to compile for issue #1254 with the following error:

Can't find any papers to compile :-(

@labarba

This comment has been minimized.

Copy link
Member

labarba commented Feb 16, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Feb 16, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Feb 16, 2019

PDF failed to compile for issue #1254 with the following error:

Can't find any papers to compile :-(

@labarba

This comment has been minimized.

Copy link
Member

labarba commented Feb 16, 2019

👋 @Amudtogal — You will need to rename your paper file as paper.md for out bot to find it!

@Amudtogal

This comment has been minimized.

Copy link

Amudtogal commented Feb 16, 2019

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Feb 24, 2019

@Amudtogal - please rename phobos_joss.md to paper.md

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Feb 28, 2019

@Amudtogal - Sorry for the delay, I was just looking here to see if you had responded, but then also thought to look at the repo, where I see that you have moved the file.

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Feb 28, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Feb 28, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Feb 28, 2019

PDF failed to compile for issue #1254 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 16 0 16 0 0 68 0 --:--:-- --:--:-- --:--:-- 68
Error producing PDF.
! Argument of \caption@ydblarg has an extra }.

\par
l.314 Robots UR5} within \texttt{Phobos}}

Looks like we failed to compile the PDF

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Feb 28, 2019

👋 @arfon - Can you help me see what's wrong with this? The figure line in paper.md looks ok. Is there a problem with having a link in a caption? Or the formatting?

@Amudtogal

This comment has been minimized.

Copy link

Amudtogal commented Feb 28, 2019

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Mar 1, 2019

ping @arfon ...

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Mar 1, 2019

@danielskatz - looks like we don't support links in captions. That said, anything that looks like a URL us auto-linked in the PDF output anyway.

Fix for the build here: dfki-ric/phobos#178

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Mar 1, 2019

👋 @gkthiruvathukal - while this paper is not quite ready yet, would you be willing to be the editor for the submission?

@Amudtogal

This comment has been minimized.

Copy link

Amudtogal commented Mar 2, 2019

@wedon generate pdf

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Mar 2, 2019

@wedon generate pdf

@Amudtogal - you're missing the h in @whedon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.