Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd 'donate' links and badges #627
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
The title is a bit misleading - I think this is for JOSS's page, not NumFOCUS's. Otherwise, this looks reasonable, though it's a bit hard to see without actually being in context in the live (or a test) site. |
xuanxu
changed the title
This comment has been minimized.
This comment has been minimized.
|
Here's a screenshot, the PR just adds a link and a badge to the cost section: Before: After: |
This comment has been minimized.
This comment has been minimized.
|
that looks good, thanks. Could we also create a donate word, button, or link in the right side "TOC" in the about page? |
This comment has been minimized.
This comment has been minimized.
|
@arfon - can you merge this one too, since I think it's much more likely that this is where potential donors will come, rather than to the github page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
xuanxu commentedNov 8, 2019
This PR adds "donate" links to the site's
Aboutpage and to the repo'sREADMEpage.Re: #623