Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Oceananigans.jl: Fast and friendly geophysical fluid dynamics on GPUs #1965

Open
whedon opened this issue Dec 18, 2019 · 32 comments
Open
Assignees
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Dec 18, 2019

Submitting author: @ali-ramadhan (Ali Ramadhan)
Repository: https://github.com/climate-machine/Oceananigans.jl
Version: v0.18.0
Editor: @kthyng
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @ali-ramadhan. Currently, there isn't an JOSS editor assigned to your paper.

@ali-ramadhan if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Dec 18, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Attempting PDF compilation. Reticulating splines etc...
@arfon

This comment has been minimized.

Copy link
Member

@arfon arfon commented Dec 18, 2019

👋 @kthyng - the submitting author suggested you as the handling editor.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

PDF failed to compile for issue #1965 with the following error:

Can't find any papers to compile :-(

@whedon whedon added the Julia label Dec 18, 2019
@ali-ramadhan

This comment has been minimized.

Copy link
Collaborator

@ali-ramadhan ali-ramadhan commented Dec 18, 2019

@whedon commands

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

@ali-ramadhan

This comment has been minimized.

Copy link
Collaborator

@ali-ramadhan ali-ramadhan commented Dec 18, 2019

@whedon generate pdf from branch joss-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019


OK DOIs

- 10.1029/96JC02775 is OK
- 10/f9wkpj is OK
- 10.1109/TPDS.2018.2872064 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.5670/oceanog.2016.66 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Dec 20, 2019

@kthyng — We're hoping you can handle this submission. I will follow up with an email now.

@ooo

This comment has been minimized.

Copy link

@ooo ooo bot commented Dec 20, 2019

👋 Hey @labarba...

Letting you know, @kthyng is currently OOO until Tuesday, January 7th 2020. ❤️

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Dec 20, 2019

@ali-ramadhan — As you can expect, a lot of our editors and reviewers are on holiday these days. I hereby request your patience, as the closest editor to the domain of your submission is unavailable until January 7th.

@ali-ramadhan

This comment has been minimized.

Copy link
Collaborator

@ali-ramadhan ali-ramadhan commented Dec 20, 2019

Hi @labarba thank you for checking in!

Of course that's totally expected. Just wanted to submit this before the holidays. Resuming in January sounds good!

@kthyng

This comment has been minimized.

Copy link

@kthyng kthyng commented Dec 20, 2019

@whedon assign @kthyng as editor

@ooo

This comment has been minimized.

Copy link

@ooo ooo bot commented Dec 20, 2019

👋 Hey @kthyng...

Letting you know, @kthyng is currently OOO until Tuesday, January 7th 2020. ❤️

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 20, 2019

OK, the editor is @kthyng

@ooo

This comment has been minimized.

Copy link

@ooo ooo bot commented Dec 20, 2019

👋 Hey @whedon...

Letting you know, @kthyng is currently OOO until Tuesday, January 7th 2020. ❤️

@kthyng

This comment has been minimized.

Copy link

@kthyng kthyng commented Dec 20, 2019

I'm happy to be editor, though I would appreciate waiting on this until January as already mentioned. It'll be hard to get reviewers now too. I'll set a reminder

@kthyng

This comment has been minimized.

Copy link

@kthyng kthyng commented Dec 20, 2019

@whedon remind @kthyng in 18 days

@ooo

This comment has been minimized.

Copy link

@ooo ooo bot commented Dec 20, 2019

👋 Hey @kthyng...

Letting you know, @kthyng is currently OOO until Tuesday, January 7th 2020. ❤️

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 20, 2019

Sorry, I can't set reminders on PRE-REVIEW issues.

@kthyng

This comment has been minimized.

Copy link

@kthyng kthyng commented Dec 20, 2019

Oh yeah, I think this is an active issue. Ok well I will just be back in a few weeks. Happy holidays!!

@ali-ramadhan

This comment has been minimized.

Copy link
Collaborator

@ali-ramadhan ali-ramadhan commented Jan 8, 2020

@whedon generate pdf from branch joss-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 8, 2020

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 8, 2020

@ali-ramadhan

This comment has been minimized.

Copy link
Collaborator

@ali-ramadhan ali-ramadhan commented Jan 8, 2020

@kthyng Thank you for agreeing to review our submission as editor!

It seems that our submission was already assigned a DOI (10.21105/joss.01965) so I was curious whether it would be safe to use the following citation in another manuscript that wishes to cite this JOSS submission, or if you would refrain from any citations during the review process.

@article{OceananigansJOSS,
  title     = {Oceananigans.jl: {Fast} and friendly geophysical fluid dynamics on GPUs},
  author    = {Ali Ramadhan and Gregory LeClaire Wagner and Chris Hill and Jean-Michel Campin and Valentin Churavy and Tim Besard and Andre Souza and Alan Edelman and John Marshall and Raffaele Ferrari},
  journal   = {The Journal of Open Source Software},
  publisher = {The Open Journal},
  volume    = {4},
  number    = {44},
  pages     = {1965},
  year      = {2020},
  doi       = {10.21105/joss.01965},
  url       = {https://doi.org/10.21105/joss.01965},
  note      = {Under review.}
}
@kthyng

This comment has been minimized.

Copy link

@kthyng kthyng commented Jan 8, 2020

@openjournals/joss-eics Is it ok to start using the joss-assigned DOI for an incoming submission while it is under review? (pre-review currently actually)

@kthyng

This comment has been minimized.

Copy link

@kthyng kthyng commented Jan 8, 2020

@funsim and @rsignell-usgs Are you interested and willing to review this submission to the Journal for Open Source Software? We ask for reviews within about 3 weeks, and you can learn more about the review process here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Jan 8, 2020

Is it ok to start using the joss-assigned DOI for an incoming submission while it is under review? (pre-review currently actually)

It's not really up to us. Using it is possible, but it won't resolve until the submission is accepted, so it will look odd to anyone trying it. I personally would instead call this an "under review" submission and not use the URL until it is accepted.

@ali-ramadhan

This comment has been minimized.

Copy link
Collaborator

@ali-ramadhan ali-ramadhan commented Jan 8, 2020

Thank you for the clarification @danielskatz, we'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.