Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: genius: analysis ready song lyric retrieval #1967

Closed
whedon opened this issue Dec 18, 2019 · 31 comments
Closed

[PRE REVIEW]: genius: analysis ready song lyric retrieval #1967

whedon opened this issue Dec 18, 2019 · 31 comments
Assignees
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Dec 18, 2019

Submitting author: @JosiahParry (Josiah Parry)
Repository: https://github.com/josiahparry/genius
Version: 2.2.1
Editor: @danielskatz
Reviewers: @bmcfee, @heraldoborges

Author instructions

Thanks for submitting your paper to JOSS @JosiahParry. Currently, there isn't an JOSS editor assigned to your paper.

@JosiahParry if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Dec 18, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon whedon added R TeX labels Dec 18, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Failed to discover a valid open source license.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019


OK DOIs

- 10.1007/978-3-642-11674-2_15 is OK

MISSING DOIs

- https://doi.org/10.1080/02699931.2019.1700482 may be missing for title: Development of emotion recognition in popular music and vocal bursts
- https://doi.org/10.1525/jpms.2018.300411 may be missing for title: Quantitative Sentiment Analysis of Lyrics in Popular Music
- https://doi.org/10.21105/joss.00037 may be missing for title: tidytext: Text Mining and Analysis Using Tidy Data Principles in R.
- https://doi.org/10.18637/jss.v059.i10 may be missing for title: Tidy data

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

@JosiahParry

This comment has been minimized.

Copy link

@JosiahParry JosiahParry commented Dec 18, 2019

I'll get to adding the missing DOIs.

Potential Reviewers:
@alexhanna: R user + NLP
@faroit: is a pyton user but seems to do work in MIR

@JosiahParry

This comment has been minimized.

Copy link

@JosiahParry JosiahParry commented Dec 18, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 18, 2019

@alexhanna

This comment has been minimized.

Copy link

@alexhanna alexhanna commented Dec 24, 2019

Hi! I don't have the bandwidth for this right now. Looks like a cool project, though.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 29, 2019

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 29, 2019

OK, the editor is @danielskatz

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 29, 2019

@JosiahParry - due to the holidays, this will likely take a little time to get reviewers assigned. Do you have additional suggestions for reviewers, perhaps based on people who have written other software in this field, with GitHub handles (but please don't tag them with @'s, since we don't want to add lots of people to the notifications of this thread) or email addresses or even just names?

@faroit

This comment has been minimized.

Copy link

@faroit faroit commented Dec 29, 2019

@danielskatz @JosiahParry I could do it but I am no expert on R software and also I work mainly with audio whereas this contribution is more focussed on text metadata if I'm not mistaken.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 29, 2019

Thanks @faroit - let me see if I can find some reviewers with closer expertise

@faroit

This comment has been minimized.

Copy link

@faroit faroit commented Dec 29, 2019

Maybe consider @bmcfee he's also a python head but has significantly more experience with core MIR

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 29, 2019

👋 @bmcfee - would you be interested in reviewing this submission for JOSS?

@bmcfee

This comment has been minimized.

Copy link
Collaborator

@bmcfee bmcfee commented Dec 30, 2019

Sure @danielskatz , thanks for the invitation! I'm not too much of an R user, so it might not be a bad idea to get an R person to chime in as well.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 30, 2019

Thanks - I'll add you to the system and continue to look for another reviewer before we start the review

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 30, 2019

@whedon add @bmcfee as reviewer

@whedon whedon assigned bmcfee and danielskatz and unassigned danielskatz Dec 30, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 30, 2019

OK, @bmcfee is now a reviewer

@JosiahParry

This comment has been minimized.

Copy link

@JosiahParry JosiahParry commented Dec 30, 2019

Thank you @danielskatz for figuring this all out! And thank you @bmcfee for being willing to review it :) It is very much appreciated.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Jan 6, 2020

Now after the holidays, I've tweeted about finding another reviewer - https://twitter.com/danielskatz/status/1214185648279572481

@faroit

This comment has been minimized.

Copy link

@faroit faroit commented Jan 6, 2020

One more suggestions: I know @heraldoborges who is an active R user and a researcher in Machine Learning/Information Retrieval.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Jan 6, 2020

👋 @heraldoborges - would you be willing to review this for JOSS? (If you haven't reviewed for JOSS before, please see our intro to reviewing and review criteria)

@heraldoborges

This comment has been minimized.

Copy link

@heraldoborges heraldoborges commented Jan 6, 2020

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Jan 6, 2020

@whedon add @heraldoborges as reviewer

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 6, 2020

OK, @heraldoborges is now a reviewer

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Jan 6, 2020

@whedon start review

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 6, 2020

OK, I've started the review over in #1995. Feel free to close this issue now!

@danielskatz danielskatz closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.