Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pyGOURGS - global optimization of n-ary tree representable problems using uniform random global search #1998

Open
whedon opened this issue Jan 7, 2020 · 23 comments
Assignees

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Jan 7, 2020

Submitting author: @pySRURGS (Sohrab Towfighi)
Repository: https://github.com/pySRURGS/pyGOURGS
Version: 0.1
Editor: @arokem
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @pySRURGS. Currently, there isn't an JOSS editor assigned to your paper.

@pySRURGS if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Jan 7, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 7, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 7, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.08 s (251.9 files/s, 60095.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1            256              0           2817
Python                           9            207            447            832
SVG                              4              2              2            194
Markdown                         2             32              0            106
TeX                              1              5              0             65
Mako                             2              1              0             28
YAML                             1              0              1             12
Bourne Shell                     1              0              0              2
-------------------------------------------------------------------------------
SUM:                            21            503            450           4056
-------------------------------------------------------------------------------
@whedon whedon added the Python label Jan 7, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 7, 2020

PDF failed to compile for issue #1998 with the following error:

ORCID looks to be the wrong length
/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon.rb:153:in block in check_orcids': Problem with ORCID (https://orcid.org/0000-0002-3050-8943) for Sohrab Towfighi (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon.rb:151:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon.rb:151:in check_orcids' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon.rb:88:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 7, 2020

Reference check summary:

OK DOIs

- 10.1186/s13040-018-0164-x is OK
- 10.1287/moor.6.1.19 is OK

MISSING DOIs

- https://doi.org/10.21105/joss.01675 may be missing for title: pySRURGS-a python package for symbolic regression by uniform random global search

INVALID DOIs

- None
@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Jan 7, 2020

👋 @arokem - would you be willing to edit this submission?

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 7, 2020

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Jan 9, 2020

👋 @arokem - a second ping...

@arokem

This comment has been minimized.

Copy link

@arokem arokem commented Jan 9, 2020

Yes. I can take this one.

@arokem

This comment has been minimized.

Copy link

@arokem arokem commented Jan 9, 2020

@whedon assign @arokem as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 9, 2020

OK, the editor is @arokem

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 9, 2020

PDF failed to compile for issue #1998 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1998/papers/JOSS/paper.md): did not find expected key while parsing a block mapping at line 2 column 1 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon.rb:125:in load_yaml'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon.rb:85:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-9847f98e9ec6/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@arokem

This comment has been minimized.

Copy link

@arokem arokem commented Jan 9, 2020

Hmm. Looks like I broke things in my PR (pySRURGS/pyGOURGS#1). But it wasn't working before either (the title was mis-rendered and the bibliography wasn't rendering)

@pySRURGS

This comment has been minimized.

Copy link

@pySRURGS pySRURGS commented Jan 9, 2020

I'll figure this out by end of today. Please leave to me.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 9, 2020

1 similar comment
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 9, 2020

@arokem

This comment has been minimized.

Copy link

@arokem arokem commented Jan 9, 2020

👍 In the meanwhile, could you please recommend potential reviewers for this article? There is a list of potential reviewers here, but feel free to suggest other people as well. Please do not tag these people into this issue for now, but provide their GitHub user-name (without the @ sign)

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 9, 2020

@pySRURGS

This comment has been minimized.

Copy link

@pySRURGS pySRURGS commented Jan 9, 2020

Consider hausen and trallard

@pySRURGS

This comment has been minimized.

Copy link

@pySRURGS pySRURGS commented Jan 9, 2020

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jan 9, 2020

@arokem

This comment has been minimized.

Copy link

@arokem arokem commented Jan 10, 2020

Unfortunately, these proposed reviewers are both currently reviewing other submissions. Let me see if I can find some other appropriate reviewers in our pool.

@arokem

This comment has been minimized.

Copy link

@arokem arokem commented Jan 10, 2020

👋 @andim: would you be willing to review this paper for JOSS?

@arokem

This comment has been minimized.

Copy link

@arokem arokem commented Jan 10, 2020

👋 @rowanc1 : would you be willing to review this paper for JOSS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.