Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upJava 8 upgrade #83
Open
Java 8 upgrade #83
+46
−87
Conversation
This comment has been minimized.
This comment has been minimized.
seinecle
commented
Jan 12, 2020
|
Two remarks on the Java 8 version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vvagaytsev commentedJan 14, 2018
Covers the issue #76 . It can be maintained in a separate branch under the different artifact name (like
language-detector-java-8) if the compatibility with the deprecated Java versions matters.The commits include some language level changes as well. There are still some code places where Java 8 Stream API can be used. I can chnage those too.
Feel free to contact me and give any feedback.
Regards,
Vladimir