Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up🚨 [security] [ruby] Update rack: 2.0.7 → 2.0.8 (patch) #349
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Dec 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=========================================
+ Coverage 89.24% 89.4% +0.16%
=========================================
Files 35 35
Lines 623 623
=========================================
+ Hits 556 557 +1
+ Misses 67 66 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
depfu bot commentedDec 18, 2019
Advisory: CVE-2019-16782
Disclosed: December 18, 2019
URL: https://github.com/rack/rack/security/advisories/GHSA-hrqr-hxpp-chr3
Possible information leak / session hijack vulnerability
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Commits
See the full diff on Github. The new version differs by 14 commits:
Bumping version
Introduce a new base class to avoid breaking when upgrading
Add a version prefix to the private id to make easier to migrate old values
Fallback to the public id when reading the session in the pool adapter
Also drop the session with the public id when destroying sessions
Fallback to the legacy id when the new id is not found
Add the private id
revert conditionals to master
remove NullSession
remove || raise and get closer to master
store hashed id, send public id
use session id objects
remove more nils
try to ensure we always have some kind of object
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands