Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] [ruby] Update rack: 2.0.7 → 2.0.8 (patch) #349

Merged
merged 1 commit into from Dec 18, 2019

Conversation

@depfu
Copy link
Contributor

depfu bot commented Dec 18, 2019


🚨 Your version of rack has known security vulnerabilities 🚨

Advisory: CVE-2019-16782
Disclosed: December 18, 2019
URL: https://github.com/rack/rack/security/advisories/GHSA-hrqr-hxpp-chr3

Possible information leak / session hijack vulnerability

There's a possible information leak / session hijack vulnerability in Rack.

Attackers may be able to find and hijack sessions by using timing attacks
targeting the session id. Session ids are usually stored and indexed in a
database that uses some kind of scheme for speeding up lookups of that
session id. By carefully measuring the amount of time it takes to look up
a session, an attacker may be able to find a valid session id and hijack
the session.

The session id itself may be generated randomly, but the way the session is
indexed by the backing store does not use a secure comparison.

Impact:

The session id stored in a cookie is the same id that is used when querying
the backing session storage engine. Most storage mechanisms (for example a
database) use some sort of indexing in order to speed up the lookup of that
id. By carefully timing requests and session lookup failures, an attacker
may be able to perform a timing attack to determine an existing session id
and hijack that session.


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rack (2.0.7 → 2.0.8) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 14 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Dec 18, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #349 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #349      +/-   ##
=========================================
+ Coverage   89.24%   89.4%   +0.16%     
=========================================
  Files          35      35              
  Lines         623     623              
=========================================
+ Hits          556     557       +1     
+ Misses         67      66       -1
Impacted Files Coverage Δ
test/helpers/wasapi_files_helper_test.rb 100% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6debe89...cc893de. Read the comment docs.

@ruebot ruebot merged commit dd655c9 into master Dec 18, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 6debe89...cc893de
Details
codecov/project 89.4% (+0.16%) compared to 6debe89
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rack-2.0.8 branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.