Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test against Python 3.8 #1363

Merged
merged 5 commits into from Dec 5, 2019
Merged

Fix and test against Python 3.8 #1363

merged 5 commits into from Dec 5, 2019

Conversation

@benclifford
Copy link
Contributor

benclifford commented Oct 16, 2019

This updates codeutil.py with corresponding changes from ipyparallel to deal with a changed API in Python 3.8.

It also adds python 3.8 to CI

benclifford added 2 commits Nov 25, 2019
@benclifford benclifford marked this pull request as ready for review Dec 5, 2019
@benclifford benclifford changed the title Run CI testing against Python 3.8 Fix and test against Python 3.8 Dec 5, 2019
@benclifford benclifford requested a review from yadudoc Dec 5, 2019
@@ -23,12 +23,14 @@ def code_ctor(*args):


def reduce_code(co):
args = [co.co_argcount, co.co_nlocals, co.co_stacksize,
args = [co.co_argcount, co.co_nlocals, co.co_stacksize,

This comment has been minimized.

Copy link
@yadudoc

yadudoc Dec 5, 2019

Member

Is this extra whitespace intentional ?

This comment has been minimized.

Copy link
@benclifford

benclifford Dec 5, 2019

Author Contributor

It comes from re-copying the original at ipyparallel/serialize/codeutil.py where it is indented that way. i've changed it back.

parsl/executors/serialize/codeutil.py Show resolved Hide resolved
@yadudoc
yadudoc approved these changes Dec 5, 2019
@yadudoc yadudoc merged commit de8db4d into master Dec 5, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@yadudoc yadudoc deleted the benc-3.8 branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.